From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Samuel Ortiz <sameo@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"\\\"De-Schrijver Peter (Nokia-D/Helsinki)\\\""
<Peter.De-Schrijver@nokia.com>,
Eduardo Valentin <eduardo.valentin@nokia.com>
Subject: [PATCH 1/1] twl4030-regulator: Remove regulator from all groups when disabling
Date: Fri, 20 Nov 2009 18:29:19 +0200 [thread overview]
Message-ID: <1258734559-15594-1-git-send-email-eduardo.valentin@nokia.com> (raw)
Just remove regulator from all groups when disabling. This way we
avoid problems if boot loader touches twl4030 registers.
Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
---
drivers/regulator/twl4030-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
index e2032fb..27b3115 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -126,7 +126,7 @@ static int twl4030reg_disable(struct regulator_dev *rdev)
if (grp < 0)
return grp;
- grp &= ~P1_GRP;
+ grp &= ~(P1_GRP & P2_GRP | P3_GRP);
return twl4030reg_write(info, VREG_GRP, grp);
}
--
1.6.5.7.g9ecb2
next reply other threads:[~2009-11-20 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 16:29 Eduardo Valentin [this message]
2009-11-20 17:08 ` Eduardo Valentin
2009-11-20 19:07 ` Liam Girdwood
2009-11-23 7:08 ` Eduardo Valentin
2009-11-23 10:55 ` Liam Girdwood
2009-11-20 17:15 Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258734559-15594-1-git-send-email-eduardo.valentin@nokia.com \
--to=eduardo.valentin@nokia.com \
--cc=Peter.De-Schrijver@nokia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®