From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbZKTReq (ORCPT ); Fri, 20 Nov 2009 12:34:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754550AbZKTReq (ORCPT ); Fri, 20 Nov 2009 12:34:46 -0500 Received: from ey-out-2122.google.com ([74.125.78.27]:47624 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754468AbZKTRep (ORCPT ); Fri, 20 Nov 2009 12:34:45 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=scHEEhLPWbIl6w8lipt8d39DGRBL785+ATU2pK6dqIeqyQ9wmtGJ9eFYGIY4EfgvqS xgemwPDNGzAbje2SIuD5E6sreUklT/zHaI8sj68UqhboexnJ3KNjMYqcxN4NjJmX//ib golTxj3q8te4B2RY/pgeHl00wcwG7L1B/1icM= From: Frederic Weisbecker To: LKML Cc: LKML , Frederic Weisbecker , Jeff Mahoney , Chris Mason , Ingo Molnar , Alexander Beregalov , Laurent Riffard , Thomas Gleixner Subject: [PATCH] kill-the-bkl/reiserfs: turn GFP_ATOMIC flag to GFP_NOFS in reiserfs_get_block() Date: Fri, 20 Nov 2009 18:34:50 +0100 Message-Id: <1258738490-5856-1-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.6.2.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GFP_ATOMIC was used in reiserfs_get_block to not lose the Bkl so that nobody can modify the tree in the middle of its work. Now that we kicked out the bkl, we can use a more friendly flag. We use GFP_NOFS here because we already hold the reiserfs lock. Signed-off-by: Frederic Weisbecker Cc: Jeff Mahoney Cc: Chris Mason Cc: Ingo Molnar Cc: Alexander Beregalov Cc: Laurent Riffard Cc: Thomas Gleixner --- fs/reiserfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index 0d493a3..3a28e77 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c @@ -932,7 +932,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block, if (blocks_needed == 1) { un = &unf_single; } else { - un = kzalloc(min(blocks_needed, max_to_insert) * UNFM_P_SIZE, GFP_ATOMIC); // We need to avoid scheduling. + un = kzalloc(min(blocks_needed, max_to_insert) * UNFM_P_SIZE, GFP_NOFS); if (!un) { un = &unf_single; blocks_needed = 1; -- 1.6.2.3