From: Mike Frysinger <vapier@gentoo.org>
To: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] kconfig: display an error message when aborting
Date: Tue, 24 Nov 2009 23:48:42 -0500 [thread overview]
Message-ID: <1259124522-26050-1-git-send-email-vapier@gentoo.org> (raw)
If the Kconfig option causes an open() failure (like one that starts with
an underscore), there should be an error message shown since we're going
to be exiting with an error code. Otherwise, the reason for the failure
can really only be diagnosed with strace or something similar.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
scripts/kconfig/confdata.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index b55e72f..e2644b4 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -640,6 +640,8 @@ static int conf_split_config(void)
fd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
if (fd == -1) {
if (errno != ENOENT) {
+ conf_warning("sym '%s' with path '%s': %s",
+ sym->name, path, strerror(errno));
res = 1;
break;
}
--
1.6.5.3
next reply other threads:[~2009-11-25 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 4:48 Mike Frysinger [this message]
2009-11-26 11:15 ` Michal Marek
2009-11-26 19:03 ` Mike Frysinger
2009-11-26 20:07 ` Michal Marek
2009-11-26 20:12 ` Mike Frysinger
2009-11-26 20:24 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259124522-26050-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®