From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dev@uclinux.org, David Howells <dhowells@redhat.com>,
David McCullough <davidm@snapgear.com>,
Greg Ungerer <gerg@uclinux.org>, Paul Mundt <lethal@linux-sh.org>
Cc: linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Jie Zhang <jie.zhang@analog.com>
Subject: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()
Date: Wed, 25 Nov 2009 00:55:03 -0500 [thread overview]
Message-ID: <1259128503-28276-1-git-send-email-vapier@gentoo.org> (raw)
From: Jie Zhang <jie.zhang@analog.com>
The mmu code uses the copy_*_user_page() variants in access_process_vm()
rather than copy_*_user() as the former includes an icache flush. This is
important when doing things like setting software breakpoints with gdb.
So switch the nommu code over to do the same.
Signed-off-by: Jie Zhang <jie.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
mm/nommu.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index 9876fa0..51ae9be 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1889,9 +1889,11 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in
/* only read or write mappings where it is permitted */
if (write && vma->vm_flags & VM_MAYWRITE)
- len -= copy_to_user((void *) addr, buf, len);
+ copy_to_user_page(vma, NULL, NULL,
+ (void *) addr, buf, len);
else if (!write && vma->vm_flags & VM_MAYREAD)
- len -= copy_from_user(buf, (void *) addr, len);
+ copy_from_user_page(vma, NULL, NULL,
+ buf, (void *) addr, len);
else
len = 0;
} else {
--
1.6.5.3
next reply other threads:[~2009-11-25 5:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 5:55 Mike Frysinger [this message]
2009-11-25 6:16 ` [uClinux-dev] " Jamie Lokier
2009-11-25 6:27 ` Jie Zhang
2009-11-25 6:51 ` Paul Mundt
2009-11-25 11:49 ` Jamie Lokier
2009-11-25 14:14 ` Jie Zhang
2009-11-25 18:39 ` Mike Frysinger
2009-11-25 6:19 ` David McCullough
2009-11-25 23:22 ` Greg Ungerer
2009-12-02 14:36 ` David Howells
2009-12-02 15:00 ` Jie Zhang
2009-12-02 14:45 ` David Howells
2009-12-02 15:07 ` Jie Zhang
2009-12-08 10:57 ` David Howells
2009-12-08 13:37 ` Jie Zhang
2009-12-08 14:19 ` David Howells
2009-12-08 14:30 ` Jie Zhang
2009-12-09 0:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259128503-28276-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=jie.zhang@analog.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®