mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
To: ext Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "broonie@opensource.wolfsonmicro.com" 
	<broonie@opensource.wolfsonmicro.com>,
	"dbrownell@users.sourceforge.net"
	<dbrownell@users.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"De-Schrijver Peter (Nokia-D/Helsinki)" 
	<Peter.De-Schrijver@nokia.com>,
	"Valentin Eduardo (Nokia-D/Helsinki)"
	<eduardo.valentin@nokia.com>
Subject: Re: [PATCHv2 1/3] twl4030-regulator: Add all TWL regulators to twreg_info
Date: Wed, 25 Nov 2009 16:22:43 +0200	[thread overview]
Message-ID: <1259158963.6303.5.camel@keskisaa-workstation> (raw)
In-Reply-To: <1259156960.3697.74.camel@odin>

On Wed, 2009-11-25 at 14:49 +0100, ext Liam Girdwood wrote:
> On Wed, 2009-11-25 at 15:38 +0200, Juha Keski-Saari wrote:
> > Regrettably it seems I slipped a mistake into this patch which took out
> > the regulators VAUX1-3. Below is a version which removes this issue
> > 
> 
> Ah, I've just applied and pushed this series. Can you redo against
> voltage for-next ?
> 
> Thanks
> 
> Liam

Here are the additions done on recent voltage-2.6/for-next, my apologies
for the extra work

>From 03578bd4f927f7777557be6d473eb0011b80608a Mon Sep 17 00:00:00 2001
From: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
Date: Wed, 25 Nov 2009 16:18:35 +0200
Subject: [PATCH] twl4030-regulator: Fixes VAUX1-3 exclusion introduced
in 3277b9fce0fcaa68d5947429e062163852ebc6fb

Signed-off-by: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
---
 drivers/regulator/twl4030-regulator.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/twl4030-regulator.c
b/drivers/regulator/twl4030-regulator.c
index 02100bc..477c965 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -401,6 +401,10 @@ static struct regulator_ops twl4030fixed_ops = {
  * software control over them after boot.
  */
 static struct twlreg_info twl4030_regs[] = {
+	TWL_ADJUSTABLE_LDO(VAUX1, 0x17, 1),
+	TWL_ADJUSTABLE_LDO(VAUX2_4030, 0x1b, 2),
+	TWL_ADJUSTABLE_LDO(VAUX2, 0x1b, 2),
+	TWL_ADJUSTABLE_LDO(VAUX3, 0x1f, 3),
 	TWL_ADJUSTABLE_LDO(VAUX4, 0x23, 4),
 	TWL_ADJUSTABLE_LDO(VMMC1, 0x27, 5),
 	TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
-- 
1.6.3.3




  reply	other threads:[~2009-11-25 14:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 10:04 [PATCHv2 0/3] for-next: Add all twl4030 regulators to RegFW Juha Keski-Saari
2009-11-25 10:04 ` [PATCHv2 1/3] twl4030-regulator: Add all TWL regulators to twreg_info Juha Keski-Saari
2009-11-25 13:38   ` Juha Keski-Saari
2009-11-25 13:49     ` Liam Girdwood
2009-11-25 14:22       ` Juha Keski-Saari [this message]
2009-11-25 14:33         ` Mark Brown
2009-11-25 18:19         ` Liam Girdwood
2009-11-25 10:04 ` [PATCHv2 2/3] Reset REMAP configuration in regulator probe Juha Keski-Saari
2009-11-25 10:04 ` [PATCHv2 3/3] Define critical regulators as always_on Juha Keski-Saari
2009-11-25 10:14   ` Mark Brown
2009-11-25 10:29     ` Juha Keski-Saari
2009-11-25 11:13       ` Mark Brown
2009-11-25 11:36         ` Juha Keski-Saari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259158963.6303.5.camel@keskisaa-workstation \
    --to=ext-juha.1.keski-saari@nokia.com \
    --cc=Peter.De-Schrijver@nokia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eduardo.valentin@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®