mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
	martinez.javier@gmail.com
Subject: Re: [PATCH] leds: fix the return value of ich7_lpc_probe.
Date: Sat, 28 Nov 2009 11:47:45 -0800	[thread overview]
Message-ID: <1259437665.10954.775.camel@nimitz> (raw)
In-Reply-To: <1259423290-6864-1-git-send-email-tfransosi@gmail.com>

On Sat, 2009-11-28 at 10:48 -0500, Thiago Farina wrote:
> In the function ich7_lpc_probe there is a 'return' that is not returning any
> value, but it should because the return type is int not void.
> 
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  drivers/leds/leds-ss4200.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index c7f6347..a0c4092 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -350,7 +350,7 @@ static int __devinit ich7_lpc_probe(struct pci_dev *dev,
>  	status = pci_enable_device(dev);
>  	if (status) {
>  		dev_err(&dev->dev, "pci_enable_device failed\n");
> -		return;
> +		return status;
>  	}

There's a patch in -mm to do something similar.  It should be pushed
upstream when the next set of -mm patches goes.

http://userweb.kernel.org/~akpm/mmotm/broken-out/drivers-leds-leds-ss4200c-fix-return-statement.patch

Thanks for posting this, though.  

-- Dave


      reply	other threads:[~2009-11-28 19:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 15:48 Thiago Farina
2009-11-28 19:47 ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259437665.10954.775.camel@nimitz \
    --to=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®