From: Joe Perches <joe@perches.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Eric Paris <eparis@parisplace.org>,
linux-security-module@vger.kernel.org, akpm@linux-foundation.org,
James Morris <jmorris@namei.org>
Subject: Re: [Patch] selinux: remove an unreachable line
Date: Mon, 30 Nov 2009 23:45:23 -0800 [thread overview]
Message-ID: <1259653523.21388.7.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20091201074422.4410.60874.sendpatchset@localhost.localdomain>
On Tue, 2009-12-01 at 02:41 -0500, Amerigo Wang wrote:
> This line is unreachable, remove it.
[]
> diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
> index b5407f1..a2f1034 100644
> --- a/security/selinux/ss/mls.c
> +++ b/security/selinux/ss/mls.c
> @@ -544,7 +544,6 @@ int mls_compute_sid(struct context *scontext,
> default:
> return -EINVAL;
> }
> - return -EINVAL;
> }
I think it's better to remove the default case.
next prev parent reply other threads:[~2009-12-01 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 7:41 Amerigo Wang
2009-12-01 7:45 ` Joe Perches [this message]
2009-12-01 8:31 ` Cong Wang
2009-12-01 10:33 ` James Morris
2009-12-03 8:38 ` Cong Wang
2009-12-02 12:35 ` Dan Carpenter
2009-12-03 8:39 ` Cong Wang
2009-12-03 19:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259653523.21388.7.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®