From: "Michael H. Warfield" <mhw@WittsEnd.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: mhw@WittsEnd.com, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ip2: Remove #ifdef MODULE from ip2main.c
Date: Tue, 01 Dec 2009 10:00:14 -0500 [thread overview]
Message-ID: <1259679614.8141.396.camel@canyon.wittsend.com> (raw)
In-Reply-To: <b9df5fa10912010102p405b429dg102843fe88932b9d@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2385 bytes --]
[Crud... NOW I find out that I've been dumped from all the Vger mailing
lists... Again... Sigh...]
Looks good to me.
Regards,
Mike
Signed-off-by: Michael H. Warfield <mhw@WittsEnd.com>
On Tue, 2009-12-01 at 15:02 +0600, Rakib Mullick wrote:
> ip2: Remove #ifdef MODULE completely.
>
> From kernel command line we can pass "module parameters".
> So #ifdef MODULE is obsolute now. Remove it completely.
> When CONFIG_PCI=n and building ip2main.c then we are hit
> by the following warning. So move *pdev into #ifdef CONFIG_PCI.
>
> drivers/char/ip2/ip2main.c: In function `ip2_loadmain':
> drivers/char/ip2/ip2main.c:542: warning: unused variable `pdev'
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> ---
>
> --- linus/drivers/char/ip2/ip2main.c 2009-12-01 12:41:53.000000000 +0600
> +++ rakib/drivers/char/ip2/ip2main.c 2009-12-01 12:56:56.000000000 +0600
> @@ -263,7 +263,7 @@ static int tracewrap;
> /* Macros */
> /**********/
>
> -#if defined(MODULE) && defined(IP2DEBUG_OPEN)
> +#ifdef IP2DEBUG_OPEN
> #define DBG_CNT(s) printk(KERN_DEBUG "(%s): [%x] ttyc=%d, modc=%x -> %s\n", \
> tty->name,(pCh->flags), \
> tty->count,/*GET_USE_COUNT(module)*/0,s)
> @@ -487,7 +487,6 @@ static const struct firmware *ip2_reques
> return fw;
> }
>
> -#ifndef MODULE
> /******************************************************************************
> * ip2_setup:
> * str: kernel command line string
> @@ -531,7 +530,6 @@ static int __init ip2_setup(char *str)
> return 1;
> }
> __setup("ip2=", ip2_setup);
> -#endif /* !MODULE */
>
> static int __init ip2_loadmain(void)
> {
> @@ -539,7 +537,6 @@ static int __init ip2_loadmain(void)
> int err = 0;
> i2eBordStrPtr pB = NULL;
> int rc = -1;
> - struct pci_dev *pdev = NULL;
> const struct firmware *fw = NULL;
>
> if (poll_only) {
> @@ -612,6 +609,7 @@ static int __init ip2_loadmain(void)
> case PCI:
> #ifdef CONFIG_PCI
> {
> + struct pci_dev *pdev = NULL;
> u32 addr;
> int status;
--
Michael H. Warfield (AI4NB) | (770) 985-6132 | mhw@WittsEnd.com
/\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0x674627FF | possible worlds. A pessimist is sure of it!
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 482 bytes --]
next prev parent reply other threads:[~2009-12-01 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 9:02 Rakib Mullick
2009-12-01 15:00 ` Michael H. Warfield [this message]
2009-12-04 4:14 ` Andrew Morton
2009-12-04 9:37 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259679614.8141.396.camel@canyon.wittsend.com \
--to=mhw@wittsend.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome