From: Matt Mackall <mpm@selenic.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
Mateusz Kaduk <mateusz.kaduk@gmail.com>,
Eric Anholt <eric@anholt.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
bugme-daemon@bugzilla.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Bug 14662] drm/i915: Select CONFIG_SHMEM
Date: Tue, 01 Dec 2009 14:31:23 -0600 [thread overview]
Message-ID: <1259699483.29740.1456.camel@calx> (raw)
In-Reply-To: <Pine.LNX.4.64.0912011906290.8058@sister.anvils>
On Tue, 2009-12-01 at 19:26 +0000, Hugh Dickins wrote:
> Hi Chris,
>
> I'm slightly worried by this patch which went into Linus's git yesterday.
>
> Thank you for looking into the issue, and coming up with what Mateusz
> has found to be a good workaround.
>
> But is it the right fix?
This really does look like a band-aid. There's either a real problem in
tiny-shmem or alternately something scribbling on its aops? In which
case turning shmem on is just causing something different to get
scribbled on.
--
http://selenic.com : development and support for Mercurial and Linux
prev parent reply other threads:[~2009-12-01 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 19:26 Hugh Dickins
2009-12-01 20:31 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259699483.29740.1456.camel@calx \
--to=mpm@selenic.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kaduk@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome