From: Mike Galbraith <efault@gmx.de>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] f83f9ac causes tasks running at MAX_PRIO
Date: Thu, 03 Dec 2009 02:44:27 +0100 [thread overview]
Message-ID: <1259804667.7691.19.camel@marge.simson.net> (raw)
In-Reply-To: <4B17138D.3040003@bigpond.net.au>
On Thu, 2009-12-03 at 11:25 +1000, Peter Williams wrote:
> On 02/12/09 22:49, Mike Galbraith wrote:
> > Hysterical reasons? That might have been a doorstop conversion kit for
> > O(1), but boots fine with CFS, and prio 40 tasks are history.
>
> In my (not so) humble opinion, there is still a lot of unnecessary cruft
> in sched.c that should have been removed as the final (clean up) stage
> of implementing CFS (i.e. stuff that was needed for O(1) but no longer
> serves a useful purpose). I know that the extra overhead of this code
> is probably inconsequential (and the compiler may even optimize some of
> it away) but it looks untidy and makes the code harder to understand.
>
> Recent patches that I've submitted were intended as a start to removing
> some of this cruft and I had intended to send more patches after they
> were accepted. I figured that it was better to do it as a number of
> small changes rather than one big one. Should I continue?
Certainly.
-Mike
next prev parent reply other threads:[~2009-12-03 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 13:23 Mike Galbraith
2009-12-02 11:46 ` Peter Zijlstra
2009-12-02 12:49 ` Mike Galbraith
2009-12-03 1:25 ` Peter Williams
2009-12-03 1:44 ` Mike Galbraith [this message]
2009-12-03 10:02 ` Peter Zijlstra
2009-12-02 14:03 ` Steven Rostedt
2009-12-02 16:51 ` Mike Galbraith
2009-12-09 9:55 ` [tip:sched/urgent] sched: Fix task priority bug tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259804667.7691.19.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pwil3058@bigpond.net.au \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome