From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: jayakumar.lkml@gmail.com, damm@opensource.se,
linux-kernel@vger.kernel.org
Cc: armbru@redhat.com, jeremy@goop.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 3/3] fb-defio: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers.
Date: Thu, 3 Dec 2009 10:31:58 -0500 [thread overview]
Message-ID: <1259854318-16907-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1259854318-16907-3-git-send-email-konrad.wilk@oracle.com>
The framebuffers (screenbase) these drivers present are actually
vmalloc-ed pages. There is no need for them to have the VM_IO flag set.
---
drivers/video/broadsheetfb.c | 2 +-
drivers/video/hecubafb.c | 2 +-
drivers/video/metronomefb.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c
index 509cb92..df9ccb9 100644
--- a/drivers/video/broadsheetfb.c
+++ b/drivers/video/broadsheetfb.c
@@ -470,7 +470,7 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev)
par->read_reg = broadsheet_read_reg;
init_waitqueue_head(&par->waitq);
- info->flags = FBINFO_FLAG_DEFAULT;
+ info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
info->fbdefio = &broadsheetfb_defio;
fb_deferred_io_init(info);
diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c
index 0b4bffb..f9d77ad 100644
--- a/drivers/video/hecubafb.c
+++ b/drivers/video/hecubafb.c
@@ -253,7 +253,7 @@ static int __devinit hecubafb_probe(struct platform_device *dev)
par->send_command = apollo_send_command;
par->send_data = apollo_send_data;
- info->flags = FBINFO_FLAG_DEFAULT;
+ info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
info->fbdefio = &hecubafb_defio;
fb_deferred_io_init(info);
diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
index df1f757..661bfd2 100644
--- a/drivers/video/metronomefb.c
+++ b/drivers/video/metronomefb.c
@@ -700,7 +700,7 @@ static int __devinit metronomefb_probe(struct platform_device *dev)
if (retval < 0)
goto err_free_irq;
- info->flags = FBINFO_FLAG_DEFAULT;
+ info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
info->fbdefio = &metronomefb_defio;
fb_deferred_io_init(info);
--
1.6.2.5
next prev parent reply other threads:[~2009-12-03 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 15:31 [PATCH] fb-defio: Inhibit setting VM_IO flag if FBINFO_VIRTFB is set Konrad Rzeszutek Wilk
2009-12-03 15:31 ` [PATCH 1/3] fb-defio: If FBINFO_VIRTFB is defined, do not set VM_IO flag Konrad Rzeszutek Wilk
2009-12-03 15:31 ` [PATCH 2/3] xen pvfb: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers Konrad Rzeszutek Wilk
2009-12-03 15:31 ` Konrad Rzeszutek Wilk [this message]
2009-12-04 0:35 ` [PATCH 3/3] fb-defio: " Jaya Kumar
2009-12-04 0:52 ` Jeremy Fitzhardinge
2009-12-04 1:13 ` Jaya Kumar
2009-12-03 18:50 ` [PATCH 1/3] fb-defio: If FBINFO_VIRTFB is defined, do not set VM_IO flag Jeremy Fitzhardinge
2009-12-03 18:56 ` Konrad Rzeszutek Wilk
2009-12-03 19:05 ` Jeremy Fitzhardinge
2009-12-04 0:34 ` Jaya Kumar
2009-12-04 7:42 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259854318-16907-4-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=armbru@redhat.com \
--cc=damm@opensource.se \
--cc=jayakumar.lkml@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®