mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alberto Bertogli <albertito@blitiri.com.ar>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Youquan Song <youquan.song@intel.com>,
	Alberto Bertogli <albertito@blitiri.com.ar>
Subject: [PATCH] Fix dmar_ir_support() section mismatch
Date: Fri,  4 Dec 2009 22:31:32 -0300	[thread overview]
Message-ID: <1259976692-389-1-git-send-email-albertito@blitiri.com.ar> (raw)

dmar_ir_support() uses the static dmar_tbl variable, which is annotated as
__initdata. This causes a section mismatch because the function is not
annotated as __init.

Since it is only used by (__init) intr_remapping_supported(), fix the
mismatch by annotating it with __init.

The code was introduced by commit 074835f0, Sep 9 2009.

Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
---
 drivers/pci/dmar.c          |    2 +-
 include/linux/intel-iommu.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index b952ebc..e6aa94e 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -1370,7 +1370,7 @@ int dmar_reenable_qi(struct intel_iommu *iommu)
 /*
  * Check interrupt remapping support in DMAR table description.
  */
-int dmar_ir_support(void)
+int __init dmar_ir_support(void)
 {
 	struct acpi_table_dmar *dmar;
 	dmar = (struct acpi_table_dmar *)dmar_tbl;
diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
index 4f0a72a..46d2c21 100644
--- a/include/linux/intel-iommu.h
+++ b/include/linux/intel-iommu.h
@@ -360,6 +360,6 @@ extern void qi_flush_dev_iotlb(struct intel_iommu *iommu, u16 sid, u16 qdep,
 
 extern int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu);
 
-extern int dmar_ir_support(void);
+extern int __init dmar_ir_support(void);
 
 #endif
-- 
1.6.5.2.372.gc0502


             reply	other threads:[~2009-12-05  1:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05  1:31 Alberto Bertogli [this message]
2009-12-21  6:46 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259976692-389-1-git-send-email-albertito@blitiri.com.ar \
    --to=albertito@blitiri.com.ar \
    --cc=David.Woodhouse@intel.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=youquan.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®