From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F58E1D90DD for ; Wed, 4 Feb 2026 12:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770207648; cv=none; b=QB+ycKwlxnkmh8iyMzlRl6BBd5qntxBg7ZlybtBwPiJlU3riGj5VAGsUKoB5w0ZYoDupBZ9+ALcxxBl5GXRjn25mRsYLfttqcjpsnMw5JbjKWSbmsvWK9+j2X4/6xNQ/ZeEqduJkAYcNwIdPk0sYh4mSiHVw/NEu8Fw+l4chJDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770207648; c=relaxed/simple; bh=gn15N+sfdIGwYValid+GmhOXor/mYmu9IDiM9sjdVK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uud2+SLaJgdXqdOJjoKuOysVWQ31WUa/z4/RIikm8e4qmpRVlu07XwdnjKU8QFGwXeNr1PqCp9V3StuVFGfHNWkThfLNXFiFlPGB2xYFnI5e3yHzfQl7+Fd0dm9DhNcbIle2iWVy4RFRAstWIeLFuGDtYhiZyRHKyjqMQsQHVUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oz9D6TfU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NfoURKGQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oz9D6TfU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NfoURKGQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CIPdV787751 for ; Wed, 4 Feb 2026 12:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I3cajZE1FasL5GqCZigdP88EELfSKa8W4d3UEAbqzvQ=; b=oz9D6TfUWd+b9u13 yc0jA4Uug74pZdUKulKCnYder8O3bLexVuMoueInWboFYt5ukjzpo7eikep5aWxE MT1cs/5NxVnDc/3D+8W3HWp+pqdz4VkGud/MajrXAjS/0Fxygt5sPZjv1mdznA2z 36chcy3er6iJiIq/z8BU58loGnMMU/a9p8l/3RV8xJVlrXD9OhKwK9Ekb4rJwGqr Dycb9L3BPU0JMbn6DbE4cHlIJfRD5f5Nn/KovNK0KdHWLh7Zu+Rst4i49yjiauxV wzS0jNAXi/CbmB2gSC78Gp82NOyBrRd/QIM8JsX6nqtwOoIiiKn7X/KoQ+TWG6aq ZL0wKQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c43uxgdvd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 12:20:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c70cb31bcdso163923785a.1 for ; Wed, 04 Feb 2026 04:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770207646; x=1770812446; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I3cajZE1FasL5GqCZigdP88EELfSKa8W4d3UEAbqzvQ=; b=NfoURKGQZfO+abM2oLJzPY00+QEuuSonVgR8OkdTNkLk7HGQVdRfysoq7AXvwiWwcB tltZ8EZzgJ3BRqLSLaGZQrdWIm0WBKiR1wo4pe1Fa3AVk3XV0vL5jwVFnmpcP0lN0aT8 QhKeEVQMbOMKM9ylgZD57qKyHaRUi4jyk1DpoV0680ZFQjNNHxOsYpWkPzYRTOwUtGEN d6NbKXM2xPOQCJRjA7mZDZ92iY738DzQDv7pWu0IQjpcVhpG5ex5meVyW4mA1JvbN6LK lJtRQ8kVYqd+p7/xkAFIU/uHb1AD4/a3PRjmcLGOVxwz7dD+Weesx3ubmfilTafHylkb 9QaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770207646; x=1770812446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I3cajZE1FasL5GqCZigdP88EELfSKa8W4d3UEAbqzvQ=; b=lHrwq5aB9jHLqiJ46JOKjFkCMfk0myR4okPSh5iA6nj7/fQnQ6ToOBGueM//wti4RR XMCd7NEGQlFvFbFtYo5XsQG8pc70jE0hCC15Gr06LsW1yHW77rp6hYJY/ovVMbY51U+C /T9Hxpe4GOtK9ei+92M9NHUlSrQoYpqb4LsAUKpP3J6f3D1GcmZJdCDg7EGscwZ9aUcs AbmKFVL+0Bi/cITQyhq+W8Pma5viRP9lM20iiHEiVlwtefcTeAxUuSCsohGnD3iW9W2t MPLamlBvgnCgKZffeJKILREXSeCtDqq14Th6QiiZWwWjLTFhIqR2WyLn7DKfivVoc7Zq 5qgA== X-Forwarded-Encrypted: i=1; AJvYcCWu2lkf+Bov3lizm55fgqT9KZX33wTzo66n69j572pw2bcAFaES0R9fRpbNbaDg0nXUuGIx4Jn1GflndXk=@vger.kernel.org X-Gm-Message-State: AOJu0YyC9v9QBAnkqr/qAS6Bc2hRnR4TQnO9AQlOFHpRZ+EXWDRgtIv2 9r8536iYCfqxwp/gnvkP9zgPvOdrcD3KI0Vzh6c2raWJiiMiX+NZ3W2+UgPklLVdjJcDIpJKFh9 jkKgL9WU7AmnszRQs+o+0rxHluo7psI7MF0laohFC3KvniKSRaLWLbQGlsW8l6OVVfNE= X-Gm-Gg: AZuq6aJW2G/Y4IyOVEdQU892SLqf9/FxtBlQTNp4gE3S2hYOq0X9nUioC5dLUjlOoNS ERnPD7JDru3FOubi1zvz73A2PcaSQ+BuEyEzjLlpeRkxhMhTmLiglzvjT1qtEgl84OKZAoGrm9l wr2Pvtu804Q4ubsj2hm6I2T5VNqImULkv4rzx/siDWULnaMp/LezFgKUjdnqiRo14VsVrawFrHS 5oG79t0ACYGVHd5pjZ/MpUPYgaceu6gvYbZTU4kPK6KA5z7T7XZdntKHsCkwfarUWW9y//RMxmc kx8UA08j8wzAMmBwRmSY1MDeyAfdfjtF14h7BD09cpIGKZG6FqgniQ4ss3o3AHJEFLQ/hdXc2DD sBTlyVqZMU72lRcXWBXk8yzxfKVY1CDeaABs0bNuGKF1dLacaoMe6HWx8T5L3BPhqv1M= X-Received: by 2002:a05:620a:172b:b0:8c5:305e:ea16 with SMTP id af79cd13be357-8ca33156b6emr167462185a.8.1770207646340; Wed, 04 Feb 2026 04:20:46 -0800 (PST) X-Received: by 2002:a05:620a:172b:b0:8c5:305e:ea16 with SMTP id af79cd13be357-8ca33156b6emr167459785a.8.1770207645834; Wed, 04 Feb 2026 04:20:45 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38691f6e30asm4345941fa.10.2026.02.04.04.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 04:20:45 -0800 (PST) Message-ID: <125b00d1-d2d5-4490-b712-acc213a58d3c@oss.qualcomm.com> Date: Wed, 4 Feb 2026 13:20:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS To: Stanislav Zaikin , devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260204115645.1343750-1-zstaseg@gmail.com> <20260204115645.1343750-3-zstaseg@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260204115645.1343750-3-zstaseg@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=StqdKfO0 c=1 sm=1 tr=0 ts=6983399f cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=n7UKcF_LFDN_CY_19WMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: bI38os0jnGVWJU8DuUL5pDmj3X8R-x_x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA5MyBTYWx0ZWRfXx5ZkMaxnWYXv 1+7m9npbwxW4I4uayiuxJ1x+86Iypnt8Om08CyUE04li37HNNROnYu+yJX3aMKdIMBnCibkcMUE 95Av5W7k1Pe+3UrXbiCr/rGO6vhcgaBxSd4t/bJTEtRPj/7Y5mk5DL8wUzzVyS8+mEA4zRl9MEa ySdWI5J2bqnNTQgyzRy5pjeKMp1dlUYwctzfG/KMto0xDgqVlMIGRlCLciS7YXSiKfPQATRI1t7 VXo2cFQeu8meZguNMLMUtBaHxim+sZwmkNGc2kA+Uag0AnR0kRrgvV2tw+Q7G2kfQgAAocpLvr4 uzajmZB18TK5kR0knv3WxTQ5yoS5LOXH6qWpyrs01+YiV/7AsxsojjW9g7N9UiWQ3kSmtt8PyBO ATHr2UdEHDzn8tTb57CAl18TxVHFE91fGgBWpwbzQeI1bi2Xqt907p576stiM44nOvHGe0pipJN LYqHg3HSHjNx5eC/cdA== X-Proofpoint-ORIG-GUID: bI38os0jnGVWJU8DuUL5pDmj3X8R-x_x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_03,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040093 On 2/4/26 12:56 PM, Stanislav Zaikin wrote: > Xiaomi 12 Lite 5G is a handset released in 2022 > > This commit has the following features working: > - Display (with simple fb) > - Touchscreen > - UFS > - Power and volume buttons > - Pinctrl > - RPM Regulators > - Remoteprocs - wifi, bluetooth > - USB (Device Mode) > > Signed-off-by: Stanislav Zaikin > --- Hello, this looks good, couple nits [...] > + // S2B is really ebi.lvl but it's there for supply map completeness sake. /* C-style comments */ are preferred [...] > + /* Mainline video_mem is downstream cvp_mem */ What does that mean? CVP is strongly connected with the video hardware, but they're not quite the same > + real_video_mem: video@8ad00000 { > + reg = <0x0 0x8ad00000 0x0 0x500000>; > + no-map; > + }; > + > + ipa_gsi_mem: ipa-gsi@8b710000 { > + reg = <0x0 0x8b710000 0x0 0xa000>; > + no-map; > + }; > + > + cdsp_mem: cdsp@9c700000 { > + reg = <0x0 0x9c700000 0x0 0x1e00000>; > + no-map; > + }; > + > + ramoops@a9000000 { > + compatible = "ramoops"; > + reg = <0x0 0xa9000000 0x0 0x200000>; > + pmsg-size = <0x200000>; > + mem-type = <0x02>; = <2> would be neater If you have an easy way of modifying the (presumably) downstream-based image which you use for ramoops, you may want to add ecc-size = <8> too, so that it's more robust [...] > +&tlmm { > + gpio-reserved-ranges = <32 2>, <48 4>, <56 4>; Any chance you know what they're used for? (you can often correlate them with QUP pinctrl entries, as they're often fingerprint scanner/NFC eSE connections) If you do, please sprinkle in some comments, like in x1-crd.dtsi [...] > +&usb_1 { > + /* USB 2.0 only */ > + qcom,select-utmi-as-pipe-clk; > + > + dr_mode = "otg"; > + usb-role-switch; > + maximum-speed = "high-speed"; > + /* Remove USB3 phy */ > + phys = <&usb_1_hsphy>; > + phy-names = "usb2-phy"; Did you check whether that's the case with a ""real"" USB3 Type-C cable? Does a Type-C dongle with a HDMI/DP output work if you plug it in when running downstream? Konrad