From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18
Date: Mon, 06 Oct 2025 10:33:40 -0400 [thread overview]
Message-ID: <125ba81bb222cdffef05ef9868c68002efd61235.camel@HansenPartnership.com> (raw)
In-Reply-To: <aOPOZwp_inGui9Bx@kernel.org>
On Mon, 2025-10-06 at 17:12 +0300, Jarkko Sakkinen wrote:
> 2. Null seed was extremely bad idea. The way I'm planning to actually
> fix this is to parametrize the primary key to a persistent key
> handle
> stored into nvram of the chip instead of genration. This will
> address
> also ambiguity and can be linked directly to vendor ceritifcate
> for e.g. to perfom remote attesttion.
Just a minute, there's been no discussion or debate about this on the
list. The rationale for using the NULL seed is clearly laid out here:
https://docs.kernel.org/security/tpm/tpm-security.html
But in brief it is the only way to detect reset attacks against the TPM
and a reset attack is the single simplest attack an interposer can do.
If you think there's a problem with the approach, by all means let's
have a debate, since TPM security is always a trade off, but you can't
simply come to your own opinion and try to impose it by fiat without at
least raising whatever issue you think you've found with the parties
who contributed the code in the first place.
Regards,
James
next prev parent reply other threads:[~2025-10-06 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 15:47 Jarkko Sakkinen
2025-10-05 18:09 ` Linus Torvalds
2025-10-06 11:58 ` Jarkko Sakkinen
2025-10-06 14:12 ` Jarkko Sakkinen
2025-10-06 14:18 ` Jarkko Sakkinen
2025-10-06 14:30 ` Jarkko Sakkinen
2025-10-06 14:33 ` James Bottomley [this message]
2025-10-06 16:51 ` Jarkko Sakkinen
2025-10-06 16:57 ` Jarkko Sakkinen
2025-10-07 14:32 ` Jarkko Sakkinen
2025-10-07 14:38 ` Jarkko Sakkinen
2025-10-06 17:02 ` Jonathan McDowell
2025-10-06 18:50 ` Jarkko Sakkinen
2025-10-05 18:24 ` Linus Torvalds
2025-10-06 12:33 ` Jarkko Sakkinen
2025-10-06 21:40 ` Jonathan McDowell
2025-10-06 22:09 ` Linus Torvalds
2025-10-06 23:11 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125ba81bb222cdffef05ef9868c68002efd61235.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome