From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD96C4332F for ; Thu, 14 Oct 2021 12:05:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E323061056 for ; Thu, 14 Oct 2021 12:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbhJNMHz (ORCPT ); Thu, 14 Oct 2021 08:07:55 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:51374 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhJNMHy (ORCPT ); Thu, 14 Oct 2021 08:07:54 -0400 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id CB1D74001E for ; Thu, 14 Oct 2021 12:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634213148; bh=7DUeJSAMIJhPw/8ePsUW00GrvDqVU0aPI87ZO6EH914=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Oa0OKVgN0bxroOrVwuIWTN/Y65V0C2cOkyfu60/gL4VLNvPoEX5FaNeIQ5LFZU/ct ZmfSHVawB4+DWkkZ+z1Ua/UT7JAGjmdjEPZnj4rylgzUTtrgGy5T3wkTXLYJzOO6OH SJz1qgZCG+KA4berYIyQPyueWP59yB5+pPsmajwB68kVJ7a8NSRUCe1BazN+9gmDuI z3AoY3o2S888wqB16T4EQyO+dw0q8hl2VXEcDrPQv4xsMMTEWYOgUzAMDUy7qUIOdZ UFn10v4W5v841agsvVc8BchHuX+kea67AqaPYUC4F4c/I6y/CwCejTAUpC8bBZm7Ro 5zAFftXrq3XmA== Received: by mail-lf1-f72.google.com with SMTP id p42-20020a05651213aa00b003fd8935b8d6so4222585lfa.10 for ; Thu, 14 Oct 2021 05:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7DUeJSAMIJhPw/8ePsUW00GrvDqVU0aPI87ZO6EH914=; b=ZptXsMykQApC4nH9J+Wul5dCruuAnms8xwLPGigMGfJ8MPuwX6Ns1+NZcqVHXYP6of Fe6geb1lC78NosQ5Ks4gxnD+ogv0FiKKszMUlcZRm0d3K6Bmn6eArC2tO6g6+9x4ajEs AcM68K3y7ZVrkTVj9HWbNMtXyD5FgOcTY3+dk4YzTmMLBMgTwaAr18qxu0vmIPC8FBwf zaVlYr8rHgGl5n8AHCLsNBPRlgr1xjOfxLVHAfIvXIxJK4lz+y+NtITLf8BtuLg9vuUp w9kuatauJF/WrfVn4ZtmJ7R+TnWT1YB3Adtmwt3dedA8udHW0PFyNq+EwET5FCYeQTuu E44w== X-Gm-Message-State: AOAM530q19QoWBZddmcApbAhNC7Nv4dHcGZMTj/jbmSztnbANzAJ6tek Xm+0LOjL9/iEajbul7Ik93gynK3FuGgQ1Oqd2Nq6oLU6VU/yQ+MFJ0/OUxPbjlPceBNFDZLEj5X xoTbcZj1m5mjYMkXfWhz4+w46LSuboP/sC8mILHvglg== X-Received: by 2002:ac2:53b0:: with SMTP id j16mr4569255lfh.656.1634213147903; Thu, 14 Oct 2021 05:05:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCt+hiQkBxCSZOa/Bi5shuLmxG3lPR3IwYp+KgtXpG96mbai/MNiQv4N/aYOMc/bn4ZM5kOw== X-Received: by 2002:ac2:53b0:: with SMTP id j16mr4569231lfh.656.1634213147622; Thu, 14 Oct 2021 05:05:47 -0700 (PDT) Received: from [192.168.3.161] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id f10sm212322lfs.56.2021.10.14.05.05.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 05:05:47 -0700 (PDT) Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: Pass revision reg offsets To: Sam Protsenko Cc: Rob Herring , Sumit Semwal , Linux Samsung SOC , linux-arm Mailing List , devicetree , Linux Kernel Mailing List References: <20211013202110.31701-1-semen.protsenko@linaro.org> <1cd31098-ba9d-f2e3-e34c-5bada00a2696@canonical.com> From: Krzysztof Kozlowski Message-ID: <125ed340-cec7-5f65-c4c1-ab5162b420f6@canonical.com> Date: Thu, 14 Oct 2021 14:05:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/2021 14:03, Sam Protsenko wrote: > On Thu, 14 Oct 2021 at 14:48, Krzysztof Kozlowski > wrote: >> >>> >>>> Did you test it that it produces same result? Looks not - I gave it a >>>> try and got wrong revision. >>>> >>> >>> I only have Exynos850 based board, and that has 0x0 in Revision ID >>> register. But for v3 I'll try to emulate register value in the code >>> and make sure that the read value does not change with patch applied. >> >> You should get one of Odroid boards to test it. The MC1 is fairly cheap. >> > > Will do, I see how it can be useful for further work. For this series, > I'm pretty sure I can test all cases by emulating the read register > values. Would it be enough? Also, if you have some time, I'd ask you > to check v3 on your board. Yes, it's OK. I can test it. Best regards, Krzysztof