From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D31C433EF for ; Thu, 7 Apr 2022 04:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235360AbiDGEJl (ORCPT ); Thu, 7 Apr 2022 00:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbiDGEJb (ORCPT ); Thu, 7 Apr 2022 00:09:31 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 40B7D58E67; Wed, 6 Apr 2022 21:07:31 -0700 (PDT) Received: from NTHCCAS01.nuvoton.com (NTHCCAS01.nuvoton.com [10.1.8.28]) by maillog.nuvoton.com (Postfix) with ESMTP id 640071C810A3; Thu, 7 Apr 2022 12:07:29 +0800 (CST) Received: from NTHCCAS03.nuvoton.com (10.1.20.28) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 7 Apr 2022 12:07:29 +0800 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS03.nuvoton.com (10.1.20.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Thu, 7 Apr 2022 12:07:28 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS01.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2375.7 via Frontend Transport; Thu, 7 Apr 2022 12:07:28 +0800 Message-ID: <125f4a13-cd4c-7deb-6ff6-0dc2e5458bf1@nuvoton.com> Date: Thu, 7 Apr 2022 12:07:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] arm64: dts: nuvoton: Add initial support for MA35D1 Content-Language: en-US To: Arnd Bergmann CC: Krzysztof Kozlowski , "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "olof@lixom.net" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "soc@kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20220307091923.9909-1-ychuang3@nuvoton.com> <20220307091923.9909-4-ychuang3@nuvoton.com> <2669852c-5bb6-1edf-bf58-ea815f54d50f@kernel.org> From: Jacky Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/6 下午 03:43, Arnd Bergmann wrote: > On Wed, Apr 6, 2022 at 4:58 AM Jacky Huang wrote: >> On 2022/3/7 下午 06:25, Krzysztof Kozlowski wrote: >>> On 07/03/2022 10:19, Jacky Huang wrote: >> I would add the following to end of arch/arm64/Kconfig.platforms, and >> add the >> modification to this patch series. >> >> config ARCH_MA35D1 >> bool "Nuvoton MA35D1 SOC Family" >> select PINCTRL >> select PINCTRL_MA35D1 >> select PM >> select GPIOLIB >> select SOC_BUS >> select VIDEOMODE_HELPERS >> select FB_MODE_HELPERS >> help >> This enables support for Nuvoton MA35D1 SOC Family. > Selecting SOC_BUS and the gpio/pinctrl stuff is ok, but please don't > select the video helpers from the platform config, those should not > be essential for building a kernel. > > Arnd Yes, I will remove  VIDEOMODE_HELPERS and FB_MODE_HELPERS. Best Regards, Jacky