mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: tony.luck@intel.com, reinette.chatre@intel.com,
	ben.horgan@arm.com, Dave.Martin@arm.com, james.morse@arm.com,
	bp@alien8.de
Cc: corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org,
	x86@kernel.org, fustini@kernel.org, tglx@kernel.org,
	mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
	fenghuay@nvidia.com, rppt@kernel.org, arnd@arndb.de,
	kmehltretter@gmail.com, dapeng1.mi@linux.intel.com,
	elver@google.com, enelsonmoore@gmail.com, jlayton@kernel.org,
	seanjc@google.com, ewanhai-oc@zhaoxin.com,
	binbin.wu@linux.intel.com, nikunj@amd.com, ashish.kalra@amd.com,
	peterz@infradead.org, superm1@kernel.org,
	thomas.lendacky@amd.com, prathyushi.nangia@amd.com,
	kim.phillips@amd.com, ricardo.neri-calderon@linux.intel.com,
	darwi@linutronix.de, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 04/19] fs/resctrl: Introduce kernel mode enum
Date: Mon, 16 Nov 2026 14:07:04 -0600	[thread overview]
Message-ID: <125f8f2e-0ab8-4833-96a5-136c4ebd8666@amd.com> (raw)
In-Reply-To: <a0251dbaf1c493f84ef1c1dfd7afe9d1cbafcf5a.1794437052.git.babu.moger@amd.com>


On 11/11/26 16:43, Babu Moger wrote:
> Kernel work need not use the CLOSID and RMID of the user task on whose
> behalf it runs. On x86, Privilege Level Zero Association (PLZA) enables a
> CPU to use a different CLOSID and/or RMID association while executing at
> privilege level zero.
> 
> Resctrl needs common definitions of how kernel work is managed so that
> architectures can advertise the kernel modes they support and user space
> can query them and select the one to use.
> 
> Introduce enum resctrl_kernel_mode:
> 
> - RESCTRL_INHERIT_USER: Kernel work uses the CLOSID and RMID of the user
>    task.
> 
> - RESCTRL_GLOBAL_ENABLE_PER_CPU: All the kernel work uses the CLOSID
>    and/or RMID of a single resource group, which may also have user tasks
>    assigned to it. The mode can be enabled or disabled per-CPU; on a CPU
>    where it is disabled, kernel work inherits the user task's CLOSID and
>    RMID.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v7: Changelog update (Reinette) with minor changes.
>      Code comment update.
> 
> v6: changelog update and code comment update.
>      Renamed RESCTRL_ASSIGN_GLOBAL_ENABLE_PER_CPU to RESCTRL_GLOBAL_ENABLE_PER_CPU.
> 
> v5: Collapse the two global-assign modes into a single
>      RESCTRL_ASSIGN_GLOBAL_ENABLE_PER_CPU value. Update the changelog to
>      match the enum names and descriptions in the code.
> 
> v4: Updated the changelog to be generic as possible.
>      Moved the enum resctrl_kernel_mode to include/linux/resctrl.h.
>      Updated the code comments to be generic.
>      Removed resctrl_kmode_cfg from the code. This definition can be fs
>      specific only and architectures dont need to know.
>      Changed enum name to resctrl_kernel_mode from resctrl_kernel_modes.
> 
> v3: Removed resctrl_kmode definition.
>      Changed the kernel mode definitions to enum resctrl_kernel_modes.
>      Used BIT() to set/test the features.
>      Added details to changelog.
> 
> v2: New patch to handle PLZA interfaces with /sys/fs/resctrl/info/ directory.
>      https://lore.kernel.org/lkml/2ab556af-095b-422b-9396-f845c6fd0342@intel.com/
> ---
>   include/linux/resctrl.h | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index b6b4519a5190..6f3e57ec4aa3 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -716,6 +716,31 @@ int resctrl_arch_io_alloc_enable(struct rdt_resource *r, bool enable);
>    */
>   bool resctrl_arch_get_io_alloc_enabled(struct rdt_resource *r);
>   
> +/**
> + * enum resctrl_kernel_mode - Kernel modes
> + *
> + * @RESCTRL_INHERIT_USER:
> + *     Kernel work inherits the CLOSID and RMID of the user task.
> + *
> + * @RESCTRL_GLOBAL_ENABLE_PER_CPU:
> + *     All kernel work uses the CLOSID and/or RMID of a single resource
> + *     group, which may also have user tasks assigned to it. The mode can
> + *     be enabled/disabled per-CPU, all online CPUs are enabled by default.
> + *     When the mode is disabled on a CPU then the kernel work on that CPU
> + *     inherits the CLOSID and RMID from the user task, effectively the
> + *     kernel mode becomes RESCTRL_INHERIT_USER on that CPU.
> + *
> + *     On x86, CLOSID and RMID are configured independently; either or both
> + *     may differ from the user task.
> + */
> +enum resctrl_kernel_mode {
> +	RESCTRL_INHERIT_USER,
> +	RESCTRL_GLOBAL_ENABLE_PER_CPU,
> +	RESCTRL_KMODE_LAST = RESCTRL_GLOBAL_ENABLE_PER_CPU
> +};

Sashiko reported:

https://sashiko.dev/#/patchset/cover.1794437052.git.babu.moger%40amd.com?part=4
=========================================================================

Should RESCTRL_KMODE_LAST be documented in the kernel-doc comment or 
placed after a /* private: */ comment?  Without either, 
scripts/kernel-doc warns that RESCTRL_KMODE_LAST is not described in 
enum resctrl_kernel_mode.

Also, the blank comment line before "On x86, CLOSID and RMID..." ends 
the @RESCTRL_GLOBAL_ENABLE_PER_CPU section in kernel-doc, placing that 
paragraph into the general enum description instead.
=======================================================================

Will document RESCTRL_KMODE_LAST and also remove the blank line before 
the line ""On x86, CLOSID and RMID...".

Thanks
Babu



  reply	other threads:[~2026-11-16 20:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 22:43 [PATCH v7 00/19] x86,fs/resctrl: Add kernel-mode (e.g., PLZA) support to the resctrl subsystem Babu Moger
2026-11-11 22:43 ` [PATCH v7 01/19] x86/cpufeatures: Support Privilege Level Zero Association (PLZA) Babu Moger
2026-11-11 22:43 ` [PATCH v7 02/19] x86/resctrl: Add PLZA support to command-line options Babu Moger
2026-11-11 22:43 ` [PATCH v7 03/19] x86/resctrl: Add PLZA MSR definition and field layout Babu Moger
2026-11-11 22:43 ` [PATCH v7 04/19] fs/resctrl: Introduce kernel mode enum Babu Moger
2026-11-16 20:07   ` Babu Moger [this message]
2026-11-11 22:43 ` [PATCH v7 05/19] arm,x86,fs/resctrl: Introduce arch hook to program global per-CPU kernel mode Babu Moger
2026-11-11 22:43 ` [PATCH v7 06/19] fs/resctrl: Introduce data structures for kernel mode configuration Babu Moger
2026-11-11 22:44 ` [PATCH v7 07/19] fs/resctrl: Introduce resctrl_set_kmode_support() to register supported modes Babu Moger
2026-11-11 22:44 ` [PATCH v7 08/19] x86/resctrl: Register RESCTRL_GLOBAL_ENABLE_PER_CPU when PLZA is available Babu Moger
2026-11-11 22:44 ` [PATCH v7 09/19] fs/resctrl: Rearrange top-level files in info directory Babu Moger
2026-11-11 22:44 ` [PATCH v7 10/19] fs/resctrl: Add interface to display kernel mode status Babu Moger
2026-11-11 22:44 ` [PATCH v7 11/19] fs/resctrl: Add support for hidden resource group files Babu Moger
2026-11-11 22:44 ` [PATCH v7 12/19] fs/resctrl: Introduce kmode_cpus/kmode_cpus_list per rdtgroup Babu Moger
2026-11-11 22:44 ` [PATCH v7 13/19] x86,fs/resctrl: Add CPU hotplug support for kernel mode Babu Moger
2026-11-16 20:08   ` Babu Moger
2026-11-11 22:44 ` [PATCH v7 14/19] fs/resctrl: Deactivate kernel mode when the group is removed Babu Moger
2026-11-11 22:44 ` [PATCH v7 15/19] fs/resctrl: Extend info/kernel_mode to configure the kernel mode Babu Moger
2026-11-16 20:09   ` Babu Moger
2026-11-11 22:44 ` [PATCH v7 16/19] fs/resctrl: Reject mode changes for groups backing " Babu Moger
2026-11-11 22:44 ` [PATCH v7 17/19] fs/resctrl: Control visibility of global per-CPU kernel mode group files Babu Moger
2026-11-16 20:10   ` Babu Moger
2026-11-11 22:44 ` [PATCH v7 18/19] fs/resctrl: Allow userspace to write kmode_cpus/kmode_cpus_list Babu Moger
2026-11-11 22:44 ` [PATCH v7 19/19] fs/resctrl: Add kernel mode documentation and examples Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=125f8f2e-0ab8-4833-96a5-136c4ebd8666@amd.com \
    --to=babu.moger@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=arnd@arndb.de \
    --cc=ashish.kalra@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=darwi@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=elver@google.com \
    --cc=enelsonmoore@gmail.com \
    --cc=ewanhai-oc@zhaoxin.com \
    --cc=fenghuay@nvidia.com \
    --cc=fustini@kernel.org \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jlayton@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=kmehltretter@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=peterz@infradead.org \
    --cc=prathyushi.nangia@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rppt@kernel.org \
    --cc=seanjc@google.com \
    --cc=skhan@linuxfoundation.org \
    --cc=superm1@kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®