From: Joe Perches <joe@perches.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
William Allen Simpson <william.allen.simpson@gmail.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add warning about leading contination tests
Date: Sun, 06 Dec 2009 09:46:16 -0800 [thread overview]
Message-ID: <1260121576.11126.83.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20091206131324.55436006@hyperion.delvare>
On Sun, 2009-12-06 at 13:13 +0100, Jean Delvare wrote:
> Not fine with me. Placing the binary logic operator at the beginning
> of a line can be a deliberate choice, either to make complex binary
> expressions more readable, or to avoid long lines. I don't see much
> point in banning this style, which BTW is used over 8000 times in the
> current kernel tree.
Anyone that thinks that checkpatch is the
last word on linux coding style and all of
its pronouncements must be followed all the
time is simply wrong.
It's not a ban. It's neither a command nor
an edict. It's a warning. It's a notice
that leading logical continuations are not
the preferred style and it can be ignored
at will.
I think it's rather like the long line, >80
column warning. There are a whole lot more
than 8k long lines in kernel source and no
one is suggesting reformatting all of them
out of existence.
cheers, Joe
next prev parent reply other threads:[~2009-12-06 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 17:58 Joe Perches
2009-12-06 8:35 ` Eric Dumazet
2009-12-06 12:13 ` Jean Delvare
2009-12-06 17:46 ` Joe Perches [this message]
2009-12-06 18:53 ` Jean Delvare
2009-12-06 19:08 ` Joe Perches
2009-12-07 22:05 ` J. Bruce Fields
2009-12-08 0:08 ` William Allen Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260121576.11126.83.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®