From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch V2 sched: Protect sched_rr_get_param access to task->sched_class
Date: Wed, 09 Dec 2009 09:33:56 +0100 [thread overview]
Message-ID: <1260347636.5489.103.camel@laptop> (raw)
In-Reply-To: <alpine.LFD.2.00.0912090930120.3089@localhost.localdomain>
On Wed, 2009-12-09 at 09:32 +0100, Thomas Gleixner wrote:
> sched_rr_get_param calls task->sched_class->get_rr_interval(task)
> without protection against a concurrent sched_setscheduler() call
> which modifies task->sched_class.
>
> Serialize the access with task_rq_lock(task) and hand the rq pointer
> into get_rr_interval() as it's needed at least in the sched_fair
> implementation.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
next prev parent reply other threads:[~2009-12-09 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 20:24 [patch 2/2] " Thomas Gleixner
2009-12-09 8:00 ` Peter Zijlstra
2009-12-09 8:03 ` Peter Zijlstra
2009-12-09 8:06 ` Thomas Gleixner
2009-12-09 8:32 ` [patch V2 " Thomas Gleixner
2009-12-09 8:33 ` Peter Zijlstra [this message]
2009-12-09 9:53 ` [tip:sched/urgent] sched: Protect sched_rr_get_param() " tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260347636.5489.103.camel@laptop \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome