From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Carsten Emde <Carsten.Emde@osadl.org>,
Olof Johansson <olof@lixom.net>,
hpa@zytor.com, tglx@linutronix.de
Subject: Re: [PATCH][GIT PULL][v2.6.33] tracing: Remove comparing of NULL to va_list in trace_array_vprintk()
Date: Wed, 09 Dec 2009 13:05:32 -0500 [thread overview]
Message-ID: <1260381932.2146.122.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20091209061148.GA14010@elte.hu>
On Wed, 2009-12-09 at 07:11 +0100, Ingo Molnar wrote:
> -tip testing found that the Alpha defconfig fails to build. (error log
> attached below)
>
> To fix this bug i have unpulled this commit for now:
>
> efcf61a: tracing: Remove comparing of NULL to va_list in trace_array_vprintk()
>
> Thanks,
>
> Ingo
>
> ---------------->
> In file included from /home/mingo/tip/include/linux/ftrace_event.h:5,
> from /home/mingo/tip/include/trace/syscall.h:6,
> from /home/mingo/tip/include/linux/syscalls.h:71,
> from /home/mingo/tip/init/noinitramfs.c:23:
Ah, this was caused by the !CONFIG_TRACING path:
-static inline void trace_print_seq(struct seq_file *m, struct trace_seq *s)
+static inline int trace_print_seq(struct seq_file *m, struct trace_seq *s)
{
}
Will fix.
Thanks,
-- Steve
next prev parent reply other threads:[~2009-12-09 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 19:56 [PATCH] ftrace: fix trace_marker output Carsten Emde
2009-11-16 22:15 ` Steven Rostedt
2009-11-17 14:18 ` Steven Rostedt
2009-11-17 15:20 ` [PATCH][GIT PULL][v2.6.32] tracing: Fix " Steven Rostedt
2009-11-22 10:24 ` [tip:tracing/urgent] " tip-bot for Carsten Emde
2009-12-06 5:13 ` Olof Johansson
2009-12-06 9:24 ` Carsten Emde
2009-12-06 13:02 ` Carsten Emde
2009-12-06 17:50 ` Olof Johansson
2009-12-09 4:19 ` [PATCH][GIT PULL][v2.6.33] tracing: Remove comparing of NULL to va_list in trace_array_vprintk() Steven Rostedt
2009-12-09 5:56 ` Ingo Molnar
2009-12-09 6:11 ` Ingo Molnar
2009-12-09 6:15 ` Ingo Molnar
2009-12-09 14:06 ` Steven Rostedt
2009-12-09 18:05 ` Steven Rostedt [this message]
2009-12-10 7:49 ` [tip:tracing/core] " tip-bot for Carsten Emde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260381932.2146.122.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=Carsten.Emde@osadl.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=olof@lixom.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®