Re: [PATCH 04/10] tracing: __dynamic_array() also defines fields

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 2009-12-09 at 15:15 +0800, Lai Jiangshan wrote:
> dynamic array is also added to struct ftrace_event_call->fields.

Could you add to the change log which events use it. I see bprint and
print. But this change log is still lacking. It should explain what
features this fixes.

But as for the patch itself:

Acked-by: Steven Rostedt <rostedt@goodmis.org>

Thanks,

-- Steve



> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
> index 458e5bf..511bc36 100644
> --- a/kernel/trace/trace_export.c
> +++ b/kernel/trace/trace_export.c
> @@ -174,7 +174,12 @@ ftrace_format_##name(struct ftrace_event_call *unused,			\
>  		return ret;
>  
>  #undef __dynamic_array
> -#define __dynamic_array(type, item)
> +#define __dynamic_array(type, item)					\
> +	ret = trace_define_field(event_call, #type, #item,		\
> +				 offsetof(typeof(field), item),		\
> +				 0, is_signed_type(type), FILTER_OTHER);\
> +	if (ret)							\
> +		return ret;
>  
>  #undef FTRACE_ENTRY
>  #define FTRACE_ENTRY(name, struct_name, id, tstruct, print)		\
> 
>