From: Steven Rostedt <rostedt@goodmis.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Wenji Huang <wenji.huang@oracle.com>,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
tzanussi@gmail.com
Subject: Re: [PATCH]tracing: Fix inaccurate function definition in trace_events_filter.c
Date: Fri, 11 Dec 2009 09:39:24 -0500 [thread overview]
Message-ID: <1260542364.2146.351.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4B21FF84.3010509@cn.fujitsu.com>
On Fri, 2009-12-11 at 16:15 +0800, Li Zefan wrote:
> Wenji Huang wrote:
> > Use strcmp instead of strncmp to do full match.
> >
>
> It's intended to use strncmp instead of strcmp..
>
> field(char, name, size) will be treated as a STATIC_STRING by
> filter code. But this field isn't necessarily a string, it
> can be an array of chars, which may not be ended with '\0'.
> So in this case, we can't use strcmp.
>
> So do you really see incorrect filter results?
Yeah, I agree that this should be strncmp. Have you seen errors?
-- Steve
prev parent reply other threads:[~2009-12-11 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 7:58 Wenji Huang
2009-12-11 8:15 ` Li Zefan
2009-12-11 14:39 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260542364.2146.351.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tzanussi@gmail.com \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®