From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
"K.Prasad" <prasad@linux.vnet.ibm.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Jason Baron <jbaron@redhat.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 05/13] ftrace: Call trace_parser_clear() properly
Date: Sun, 13 Dec 2009 14:08:06 +0100 [thread overview]
Message-ID: <1260709694-5166-6-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1260709694-5166-1-git-send-regression-fweisbec@gmail.com>
From: Li Zefan <lizf@cn.fujitsu.com>
I found a weird behavior:
# echo 'fuse:*' > set_ftrace_filter
bash: echo: write error: Invalid argument
# cat set_ftrace_filter
fuse_dev_fasync
fuse_dev_poll
fuse_copy_do
We should call trace_parser_clear() no matter ftrace_process_regex()
returns 0 or -errno, otherwise we will actually take the unaccepted
records from ftrace_regex_release().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <4B1DC4D2.3000406@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/ftrace.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 08a3fb5..ff8aecd 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2208,10 +2208,9 @@ ftrace_regex_write(struct file *file, const char __user *ubuf,
!trace_parser_cont(parser)) {
ret = ftrace_process_regex(parser->buffer,
parser->idx, enable);
+ trace_parser_clear(parser);
if (ret)
goto out_unlock;
-
- trace_parser_clear(parser);
}
ret = read;
--
1.6.2.3
next prev parent reply other threads:[~2009-12-13 13:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 13:08 [GIT PULL] tracing updates Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 01/13] tracing: Extract duplicate ftrace_raw_init_event_foo() Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 02/13] tracing: Pull up calls to trace_define_common_fields() Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo() Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 04/13] ftrace: Return EINVAL when writing invalid val to set_ftrace_filter Frederic Weisbecker
2009-12-13 13:08 ` Frederic Weisbecker [this message]
2009-12-13 13:08 ` [PATCH 06/13] function-graph: Allow writing the same val to set_graph_function Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 07/13] tracing: Use seq file for trace_options Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 08/13] tracing: Use seq file for trace_clock Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 09/13] tracing: Remove useless trace option Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 10/13] tracing: Simplify trace_option_write() Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 11/13] tracing: Change event->profile_count to be int type Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 12/13] tracing/power: Remove two exports Frederic Weisbecker
2009-12-13 13:08 ` [PATCH 13/13] ksym_tracer: Fix compile warnings Frederic Weisbecker
2009-12-13 21:18 ` [GIT PULL] tracing updates Frederic Weisbecker
2009-12-14 8:14 ` Ingo Molnar
2009-12-14 1:03 ` Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2009-12-08 3:13 [PATCH 00/13] tracing: various cleanups and small fixes (updated) Li Zefan
2009-12-08 3:15 ` [PATCH 05/13] ftrace: Call trace_parser_clear() properly Li Zefan
2009-12-08 9:48 ` Frederic Weisbecker
2009-12-08 10:03 ` Li Zefan
2009-12-08 11:43 ` Frederic Weisbecker
2009-12-08 13:28 ` Steven Rostedt
2009-12-09 5:52 ` Steven Rostedt
2009-12-07 7:39 [PATCH 0/13] tracing: various cleanups and small fixes Li Zefan
2009-12-07 7:41 ` [PATCH 05/13] ftrace: Call trace_parser_clear() properly Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260709694-5166-6-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=arjan@linux.intel.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome