mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
	"dbrownell@users.sourceforge.net"
	<dbrownell@users.sourceforge.net>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"De-Schrijver Peter (Nokia-D/Helsinki)" 
	<Peter.De-Schrijver@nokia.com>,
	"Valentin Eduardo (Nokia-D/Helsinki)"
	<eduardo.valentin@nokia.com>
Subject: Re: [PATCH 1/1] twl4030-regulator: extend twlreg_info to contain turnon delay and remap
Date: Mon, 14 Dec 2009 09:05:17 +0200	[thread overview]
Message-ID: <1260774317.31691.20.camel@keskisaa-workstation> (raw)
In-Reply-To: <20091211103537.GC18825@rakim.wolfsonmicro.main>

On Fri, 2009-12-11 at 11:35 +0100, ext Mark Brown wrote:
> On Fri, Dec 11, 2009 at 09:53:51AM +0200, Juha Keski-Saari wrote:
> > Extend the twlreg_info structure to hold the turnon delay and remap config
> > value for regulators, and implement turnon delay in reg_enable
> 
> Hrm, what exactly are these parameters?  Are they for inital power
> sequencing or runtime things?
> 
> but for the default setting this does
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

The remap configuration is as before, just put in a nicer form to group
the values better with the regulator definitions, restoring the REMAP
configuration was intended as an initial step after bootloader to make
sure we know the configuration.

The turnon delay values are quoted by the TWL4030 Data manual as the
maximum time it may take for the regulator to reach full output after it
has been turned on. The DM also quotes a maximum wakeup time for
returning from sleep to full output, but that delay is much shorter. For
some regulators the turnon delay is theoretically long enough for the
reg_enable to return to the driver noticeably earlier than the regulator
output is actually at target level.


  reply	other threads:[~2009-12-14  7:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  7:53 Juha Keski-Saari
2009-12-11 10:35 ` Mark Brown
2009-12-14  7:05   ` Juha Keski-Saari [this message]
2009-12-14 11:31     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260774317.31691.20.camel@keskisaa-workstation \
    --to=ext-juha.1.keski-saari@nokia.com \
    --cc=Peter.De-Schrijver@nokia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eduardo.valentin@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®