From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Juergen E. Fischer" <fischer@norbit.de>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org
Subject: [PATCH 5/5] aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion
Date: Wed, 16 Dec 2009 22:36:01 +0800 [thread overview]
Message-ID: <1260974161-6934-6-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com>
The _ONSTACK variant should be used for on-stack completion,
otherwise it will break lockdep.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Juergen E. Fischer <fischer@norbit.de>
Cc: James E.J. Bottomley <James.Bottomley@suse.de>
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/aha152x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index 1e5478a..44e43b5 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -1143,7 +1143,7 @@ static int aha152x_abort(Scsi_Cmnd *SCpnt)
static int aha152x_device_reset(Scsi_Cmnd * SCpnt)
{
struct Scsi_Host *shpnt = SCpnt->device->host;
- DECLARE_COMPLETION(done);
+ DECLARE_COMPLETION_ONSTACK(done);
int ret, issued, disconnected;
unsigned char old_cmd_len = SCpnt->cmd_len;
unsigned long flags;
--
1.6.3.3
next prev parent reply other threads:[~2009-12-16 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 14:35 [PATCH 0/5] " Yong Zhang
2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang
2009-12-16 14:35 ` [PATCH 2/5] hwmon: " Yong Zhang
2009-12-16 14:35 ` [PATCH 3/5] USB: " Yong Zhang
2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang
2009-12-16 14:36 ` Yong Zhang [this message]
2009-12-16 19:00 ` Karsten Keil
2009-12-19 4:30 ` David Miller
2009-12-16 15:14 ` [PATCH 0/5] " Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260974161-6934-6-git-send-email-yong.zhang0@gmail.com \
--to=yong.zhang0@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=fischer@norbit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®