From: Phil Carmody <ext-phil.2.carmody@nokia.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [RFC 4/6] Driver core: Easy macros to encourage const attributes
Date: Thu, 17 Dec 2009 20:12:14 +0200 [thread overview]
Message-ID: <1261073536-27396-5-git-send-email-ext-phil.2.carmody@nokia.com> (raw)
In-Reply-To: <1261073536-27396-4-git-send-email-ext-phil.2.carmody@nokia.com>
It's too easy to type DEVICE_ATTR and not think of adding
a 'const', make it just as easy to get const as part of the
macro.
Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
---
include/linux/device.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index d07f90f..ea8ced6 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -165,6 +165,10 @@ struct driver_attribute {
struct driver_attribute driver_attr_##_name = \
__ATTR(_name, _mode, _show, _store)
+#define DRIVER_CATTR(_name, _mode, _show, _store) \
+const struct driver_attribute driver_attr_##_name = \
+ __ATTR(_name, _mode, _show, _store)
+
extern int __must_check driver_create_file(struct device_driver *driver,
const struct driver_attribute *attr);
extern void driver_remove_file(struct device_driver *driver,
@@ -318,6 +322,10 @@ struct device_attribute {
#define DEVICE_ATTR(_name, _mode, _show, _store) \
struct device_attribute dev_attr_##_name = __ATTR(_name, _mode, _show, _store)
+#define DEVICE_CATTR(_name, _mode, _show, _store) \
+const struct device_attribute dev_attr_##_name = \
+ __ATTR(_name, _mode, _show, _store)
+
extern int __must_check device_create_file(struct device *device,
const struct device_attribute *entry);
extern void device_remove_file(struct device *dev,
--
1.6.0.4
next prev parent reply other threads:[~2009-12-17 18:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 18:12 [RFC 0/6] Driver core: Encourage use of " Phil Carmody
2009-12-17 18:12 ` [RFC 1/6] Driver core: device_attribute parameters can often be const* Phil Carmody
2009-12-17 18:12 ` [RFC 2/6] Driver core: bin_attribute " Phil Carmody
2009-12-17 18:12 ` [RFC 3/6] Driver core: driver_attribute " Phil Carmody
2009-12-17 18:12 ` Phil Carmody [this message]
2009-12-17 18:12 ` [RFC 5/6] PM: Example of how easy it is to mark attributes const Phil Carmody
2009-12-17 18:12 ` [RFC 6/6] gpio: " Phil Carmody
2009-12-17 23:16 ` [RFC 0/6] Driver core: Encourage use of const attributes Greg KH
2009-12-18 0:42 ` Stephen Rothwell
2009-12-18 4:20 ` Greg KH
2009-12-18 13:34 ` [PATCH 0/3] " Phil Carmody
2009-12-18 13:34 ` [PATCH 1/3] Driver core: device_attribute parameters can often be const* Phil Carmody
2009-12-18 13:34 ` [PATCH 2/3] Driver core: bin_attribute " Phil Carmody
2009-12-18 13:34 ` [PATCH 3/3] Driver core: driver_attribute " Phil Carmody
2009-12-18 8:52 ` [RFC 0/6] Driver core: Encourage use of const attributes Phil Carmody
2009-12-18 16:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261073536-27396-5-git-send-email-ext-phil.2.carmody@nokia.com \
--to=ext-phil.2.carmody@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®