From: Jason Wessel <jason.wessel@windriver.com>
To: David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>,
David Airlie <airlied@linux.ie>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Clemens Ladisch <clemens@ladisch.de>
Subject: [PATCH] drm_fb_helper: fix regression in pixclock check
Date: Thu, 17 Dec 2009 17:25:03 -0600 [thread overview]
Message-ID: <1261092303-4570-1-git-send-email-jason.wessel@windriver.com> (raw)
Commit 5349ef3127c77075ff70b2014f17ae0fbcaaf199 changed pixclock to be
initialized to zero instead of -1. The validation routine always
returns -EINVAL for a valid pixclock which prevents atomic kernel mode
setting from working correctly.
CC: David Airlie <airlied@linux.ie>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 1b49fa0..7b59cf1 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -602,7 +602,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
struct drm_framebuffer *fb = fb_helper->fb;
int depth;
- if (var->pixclock != 0)
+ if (!var->pixclock)
return -EINVAL;
/* Need to resize the fb object !!! */
--
1.6.4.rc1
next reply other threads:[~2009-12-17 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 23:25 Jason Wessel [this message]
2009-12-18 7:20 ` Clemens Ladisch
2009-12-23 19:04 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261092303-4570-1-git-send-email-jason.wessel@windriver.com \
--to=jason.wessel@windriver.com \
--cc=airlied@linux.ie \
--cc=clemens@ladisch.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®