mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix CLX-N package information output
Date: Wed, 15 Apr 2020 09:59:53 -0700	[thread overview]
Message-ID: <12612c48b9d00d10350d5e07587d90ae3759101f.camel@linux.intel.com> (raw)
In-Reply-To: <20200415161043.GU185537@smile.fi.intel.com>

On Wed, 2020-04-15 at 19:10 +0300, Andy Shevchenko wrote:
> On Thu, Apr 02, 2020 at 02:07:32PM -0400, Prarit Bhargava wrote:
> > On CLX-N the perf-profile output is missing the package, die, and
> > cpu
> > output.  On CLX-N the pkg_dev struct will never be evaluated by the
> > core
> > code so pkg_dev.processed is always 0 and the package, die, and cpu
> > information is never output.
> > 
> > Set the pkg_dev.processed flag to 1 for CLX-N processors.
> 
Sorry Prarit. It took long to respond. The patch is fine. I am applying
to my tree.

-Srinivas

> I will accept this with PR from Srinivas whenever he sends one to
> public mailing list.
> 
> > Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> > Cc: andriy.shevchenko@linux.intel.com
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: platform-driver-x86@vger.kernel.org
> > ---
> >  tools/power/x86/intel-speed-select/isst-config.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> > b/tools/power/x86/intel-speed-select/isst-config.c
> > index d1ac57be0cbd..2e64b9b6eb2e 100644
> > --- a/tools/power/x86/intel-speed-select/isst-config.c
> > +++ b/tools/power/x86/intel-speed-select/isst-config.c
> > @@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int
> > cpu, void *arg1, void *arg2,
> >  
> >  		ctdp_level = &clx_n_pkg_dev.ctdp_level[0];
> >  		pbf_info = &ctdp_level->pbf_info;
> > +		clx_n_pkg_dev.processed = 1;
> >  		isst_ctdp_display_information(cpu, outf, tdp_level,
> > &clx_n_pkg_dev);
> >  		free_cpu_set(ctdp_level->core_cpumask);
> >  		free_cpu_set(pbf_info->core_cpumask);
> > -- 
> > 2.18.2
> > 


      reply	other threads:[~2020-04-15 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 18:07 Prarit Bhargava
2020-04-15 16:10 ` Andy Shevchenko
2020-04-15 16:59   ` Srinivas Pandruvada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12612c48b9d00d10350d5e07587d90ae3759101f.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®