From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932126AbbCICpO (ORCPT ); Sun, 8 Mar 2015 22:45:14 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:36887 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570AbbCICnw (ORCPT ); Sun, 8 Mar 2015 22:43:52 -0400 X-AuditID: cbfee6a3-f79a86d00000396e-0c-54fd08e799c8 Date: Mon, 09 Mar 2015 02:43:51 +0000 (GMT) From: Yuan Zhong Subject: [f2fs-dev] [PATCH 1/3 v2] f2fs:remove unnecessary condition judgment To: Jaegeuk Kim , =?gb2312?Q?=3F=3F=3F?= Cc: "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Reply-to: yuan.mark.zhong@samsung.com MIME-version: 1.0 X-MTR: 20150309024207358@yuan.mark.zhong Msgkey: 20150309024207358@yuan.mark.zhong X-EPLocale: zh_CN.gb2312 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150309023616353@yuan.mark.zhong X-ParentMTR: 20150309023616353@yuan.mark.zhong X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=gb2312 MIME-version: 1.0 Message-id: <1261310236.1196121425869030109.JavaMail.weblogic@epmlwas01c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t/tPt3nHH9DDGYf4ba4vGsOmwOjx+dN cgGMUVw2Kak5mWWpRfp2CVwZz5/OYS84wFGx6shbtgbGBRxdjJwcQgJaEu9/PGQGsSUETCS+ HDzLCGGLSVy4t56ti5ELqGYOo8Seww/YQBIsAioSL6c8YwWx2QT0Je7s2wfWICzgK7Hx/imw QSICURLvl85mB2lmFrjJKPFrwlqgBg6gSaoSx9eWgtTwCghKnJz5hAVimYZE/43DbCAlvAKa Eqf+WoKYEgISEqsuRUJU8ErMaH8KVS0nMe3rGqiTpSXOz9oAd/Li74+h4vwSx27vYIKwBSSm njkIVaMrcXfmZzYIW19i688JjDD1u04tZ4bZdX/LXKheCYmtLU/AvmUWUJSY0v2QHcLWkpjX 8JsJ3Se8Ap4S1w/dYJrAKDsLSWoWkvZZSNqR1SxgZFnFKJpakFxQnJReYaxXnJhbXJqXrpec n7uJERzNzxbvYPx/3voQowAHoxIP744Tf0KEWBPLiitzDzFKcDArifCKngQK8aYkVlalFuXH F5XmpBYfYpTmYFES5/1/LjdESCA9sSQ1OzW1ILUIJsvEwSnVwGgT2Pc2gskge0dCn3koYyb/ 0/Ylr5ecizlR1nmf32FWME9AxeWYl9v27jvxUFqge0oGr+icFoMVW8w2Kp7Mn1JxrbI6/NIJ kVmBr004LLQanD1fWt4wTih5NW3eHdZKd7XbsYf5tN41SMyMC1d7FN8oNpX796SDv2+H3BBa tH0bw12jtLdTJiuxFGckGmoxFxUnAgCl86Fj4gIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t292jLQc005696 Remove the unnecessary condition judgment, because 'max_slots' has been initialized to '0' at the beginging of the function, as following: if (max_slots) *max_slots = 0; Signed-off-by: Yuan Zhong --- fs/f2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 590aeef..1f1a1bc 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -139,7 +139,7 @@ struct f2fs_dir_entry *find_target_dentry(struct qstr *name, int *max_slots, !memcmp(d->filename[bit_pos], name->name, name->len)) goto found; - if (max_slots && *max_slots >= 0 && max_len > *max_slots) { + if (max_slots && max_len > *max_slots) { *max_slots = max_len; max_len = 0; } -- 1.7.9.5{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I