From: Mike Galbraith <efault@gmx.de>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
Cc: Willy Tarreau <w@1wt.eu>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [stable] Regression in 2.6.32.2: segfault on halt
Date: Sun, 20 Dec 2009 15:30:00 +0100 [thread overview]
Message-ID: <1261319400.6105.27.camel@marge.simson.net> (raw)
In-Reply-To: <4B2E264E.4090805@googlemail.com>
On Sun, 2009-12-20 at 14:27 +0100, Holger Hoffstätte wrote:
> Took me some time (still learning git - I usually use hg) but I just
> managed to fix it by reverting not the bisected revision (won't compile
> any longer), but the follow-up "cleanup & fix":
>
> >From 35c1ee3e78766d5666f418af638def9c67e63ecb Mon Sep 17 00:00:00 2001
> From: Mike Galbraith <efault@gmx.de>
> Date: Tue, 10 Nov 2009 03:50:02 +0100
> Subject: [PATCH] sched: Fix and clean up rate-limit newidle code
>
> commit eae0c9dfb534cb3449888b9601228efa6480fdb5 upstream.
>
> Commit 1b9508f, "Rate-limit newidle" has been confirmed to fix
> the netperf UDP loopback regression reported by Alex Shi.
>
> This is a cleanup and a fix:
>
> - moved to a more out of the way spot
>
> - fix to ensure that balancing doesn't try to balance
> runqueues which haven't gone online yet, which can
> mess up CPU enumeration during boot.
>
> Reported-by: Alex Shi <alex.shi@intel.com>
> Reported-by: Zhang, Yanmin <yanmin_zhang@linux.intel.com>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> LKML-Reference: <1257821402.5648.17.camel@marge.simson.net>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> aka:
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=35c1ee3e78766d5666f418af638def9c67e63ecb
>
> Reverting this from a clean 32.2 tree results in a kernel with newidle
> fix, but still working halt/reboot. The only difference between this and
> the bisected one is the additional change in cpumask handling.
>
> That was more fun than expected :)
Egad. Reverting the cpumask bit alone cures the problem?
-Mike
next prev parent reply other threads:[~2009-12-20 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 15:10 Holger Hoffstaette
2009-12-20 5:48 ` Willy Tarreau
2009-12-20 11:55 ` Holger Hoffstätte
2009-12-20 13:06 ` Willy Tarreau
2009-12-20 13:27 ` Holger Hoffstätte
2009-12-20 14:30 ` Mike Galbraith [this message]
2009-12-20 15:24 ` Holger Hoffstätte
[not found] ` <4B2E4056.50708@googlemail.com>
[not found] ` <1261339759.9188.4.camel@marge.simson.net>
[not found] ` <4B2EA5F8.4030907@googlemail.com>
[not found] ` <1261372511.6048.3.camel@marge.simson.net>
[not found] ` <4B2F3DD3.5090506@googlemail.com>
[not found] ` <1261387782.25983.5.camel@marge.simson.net>
2009-12-21 9:35 ` Mike Galbraith
2009-12-20 14:05 ` Mike Galbraith
2009-12-20 14:19 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261319400.6105.27.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=holger.hoffstaette@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome