mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ingo Molnar <mingo@elte.hu>, Andy Whitcroft <apw@canonical.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, peterz@infradead.org,
	efault@gmx.de, akpm@linux-foundation.org, tglx@linutronix.de
Subject: [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on multiple lines
Date: Sun, 20 Dec 2009 11:44:15 -0800	[thread overview]
Message-ID: <1261338255.30458.222.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20091220191531.GA17878@elte.hu>

On Sun, 2009-12-20 at 20:15 +0100, Ingo Molnar wrote:
> Checkpatch should warn about printk 
> lines that end with a '"', those are almost always a sign of some ill-advised 
> break-the-string artifact.

Perhaps something like this:

diff from Andy Whitcroft's testing script,
where logFunctions is defined.
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

--- a/scripts/checkpatch.pl-testing	2009-12-20 11:35:28.000000000 -0800
+++ b/scripts/checkpatch.pl-testing	2009-12-20 11:35:46.000000000 -0800
@@ -1398,6 +1398,11 @@
 			WARN("line over 80 characters\n" . $herecurr);
 		}
 
+#Logging function format split over multiple lines
+		if ($line =~ /^\+\s*$logFunctions.*"\s*$/) {
+			WARN("Don't split logging function format\n" . $herecurr);
+		}
+
 # check for adding lines without a newline.
 		if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
 			WARN("adding a line without newline at end of file\n" . $herecurr);



  reply	other threads:[~2009-12-20 19:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-20 13:23 sched: restore sanity Peter Zijlstra
2009-12-20 14:27 ` Arjan van de Ven
2009-12-20 14:49 ` Ingo Molnar
2009-12-20 14:51   ` Peter Zijlstra
     [not found]     ` <236ccac0912200703g464912b1r421497ebf3b6ebc6@mail.gmail.com>
2009-12-20 15:05       ` San Mehat
2009-12-20 15:19         ` Peter Zijlstra
2009-12-20 15:28           ` Mike Galbraith
2009-12-20 15:36           ` San Mehat
2009-12-20 17:22           ` Joe Perches
2009-12-20 17:36             ` Peter Zijlstra
2009-12-20 17:50               ` Ingo Molnar
2009-12-20 17:57               ` Joe Perches
2009-12-20 17:37             ` Ingo Molnar
2009-12-20 18:17             ` Arjan van de Ven
2009-12-20 18:21               ` Joe Perches
2009-12-21  0:48                 ` Arjan van de Ven
2009-12-21  1:20                   ` Joe Perches
2009-12-22 10:11             ` Al Viro
2009-12-20 17:22   ` Joe Perches
2009-12-20 18:00 ` [tip:sched/urgent] sched: Restore printk sanity tip-bot for Peter Zijlstra
2009-12-20 20:36   ` Geert Uytterhoeven
2009-12-21 20:40   ` Valdis.Kletnieks
2009-12-25 13:26   ` Pavel Machek
2009-12-25 18:45     ` Ingo Molnar
2009-12-27  0:45       ` Valdis.Kletnieks
2009-12-27  5:56         ` Ingo Molnar
     [not found]     ` <1261756819.4937.216.camel@laptop>
2009-12-25 18:39       ` Joe Perches
2009-12-25 18:47       ` Pavel Machek
2009-12-20 18:06 ` tip-bot for Peter Zijlstra
2009-12-20 18:55   ` Joe Perches
2009-12-20 19:15     ` Ingo Molnar
2009-12-20 19:44       ` Joe Perches [this message]
2009-12-20 20:10         ` [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on multiple lines Ingo Molnar
2009-12-20 22:12       ` [tip:sched/urgent] sched: Restore printk sanity tytso
2009-12-21  1:11         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261338255.30458.222.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®