mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH] drivers/atm/lanai.c: use %pM to show MAC address
Date: Wed, 30 Dec 2009 10:59:46 -0800	[thread overview]
Message-ID: <1262199586.2545.43.camel@Joe-Laptop.home> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090200F645@mi8nycmail19.Mi8.com>

On Wed, 2009-12-30 at 13:50 -0500, H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
> diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
> index cf97c34..7fe7c32 100644
> --- a/drivers/atm/lanai.c
> +++ b/drivers/atm/lanai.c
[]
> @@ -2483,14 +2481,8 @@ static int lanai_proc_read(struct atm_dev *atmdev, loff_t *pos, char *page)
>  		return sprintf(page, "revision: board=%d, pci_if=%d\n",
>  		    lanai->board_rev, (int) lanai->pci->revision);
>  	if (left-- == 0)
> -		return sprintf(page, "EEPROM ESI: "
> -		    "%02X:%02X:%02X:%02X:%02X:%02X\n",
> -		    lanai->eeprom[EEPROM_MAC + 0],
> -		    lanai->eeprom[EEPROM_MAC + 1],
> -		    lanai->eeprom[EEPROM_MAC + 2],
> -		    lanai->eeprom[EEPROM_MAC + 3],
> -		    lanai->eeprom[EEPROM_MAC + 4],
> -		    lanai->eeprom[EEPROM_MAC + 5]);
> +		return sprintf(page, "EEPROM ESI: %pM\n",
> +		    &lanai->eeprom[EEPROM_MAC]);

This is a user-visible change from upper case to lower case.
Probably doesn't matter, but maybe...



  reply	other threads:[~2009-12-30 18:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30 18:50 H Hartley Sweeten
2009-12-30 18:59 ` Joe Perches [this message]
2009-12-30 23:56   ` Henrique de Moraes Holschuh
2010-01-05 16:26 H Hartley Sweeten
2010-01-07  9:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262199586.2545.43.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®