From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbZL3TVi (ORCPT ); Wed, 30 Dec 2009 14:21:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752533AbZL3TVh (ORCPT ); Wed, 30 Dec 2009 14:21:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35246 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbZL3TVh (ORCPT ); Wed, 30 Dec 2009 14:21:37 -0500 Subject: [PATCH] libsrp: fix compile failure From: James Bottomley To: Stefani Seibold , Andrew Morton , Linus Torvalds Cc: linux-kernel , linux-scsi Content-Type: text/plain; charset="UTF-8" Date: Wed, 30 Dec 2009 13:21:06 -0600 Message-Id: <1262200866.2749.226.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 45465487897a1c6d508b14b904dc5777f7ec7e04 Author: Stefani Seibold Date: Mon Dec 21 14:37:26 2009 -0800 kfifo: move struct kfifo in place Caused a compile failure in ibmvscsitgt.c because it changed a pointer to kfifo in the libsrp.h structure to a direct inclusion without including . The fix is simple, just add the include, but how did this happen? This change, introduced at -rc2, hardly looks like a bug fix, and it clearly didn't go through linux-next, which would have picked up this compile failure (it only occurs on ppc because of the ibm virtual scsi target). James --- diff --git a/include/scsi/libsrp.h b/include/scsi/libsrp.h index 07e3add..f4105c9 100644 --- a/include/scsi/libsrp.h +++ b/include/scsi/libsrp.h @@ -2,6 +2,7 @@ #define __LIBSRP_H__ #include +#include #include #include #include