From: Frederic Weisbecker <fweisbec@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Christian Kujau <lists@nerdbynature.de>,
Alexander Beregalov <a.beregalov@gmail.com>,
Chris Mason <chris.mason@oracle.com>, Ingo Molnar <mingo@elte.hu>
Subject: [GIT PULL] reiserfs fixes
Date: Sat, 2 Jan 2010 02:27:16 +0100 [thread overview]
Message-ID: <1262395636-8647-1-git-send-regression-fweisbec@gmail.com> (raw)
Linus,
Please pull the reiserfs/kill-bkl branch that can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
reiserfs/kill-bkl
These changes fix a lot of lock inversions, some of them were
triggering soft lockups very easily in xattrs operations.
As the reiserfs lock is a giant lock (in reiserfs scope),
these dependency inversions couldn't get smart fixes without a deep
locking rewrite.
That's why you'll mostly find dependency inversion fixes based on
such pattern:
reiserfs_write_unlock()
mutex_lock(random_lock)
reiserfs_write_lock()
This is not beautiful but at least that's better than the bkl.
Oh and I expect other lock inversions will get reported in
the future due to rare and then yet untested paths.
Thanks,
Frederic
---
Frederic Weisbecker (13):
reiserfs: Fix possible recursive lock
reiserfs: Fix reiserfs lock and journal lock inversion dependency
reiserfs: Fix reiserfs lock <-> inode mutex dependency inversion
reiserfs: Fix remaining in-reclaim-fs <-> reclaim-fs-on locking inversion
reiserfs: Fix reiserfs lock <-> i_xattr_sem dependency inversion
reiserfs: Warn on lock relax if taken recursively
reiserfs: Fix reiserfs lock <-> i_mutex dependency inversion on xattr
reiserfs: Relax reiserfs lock while freeing the journal
reiserfs: Relax lock before open xattr dir in reiserfs_xattr_set_handle()
reiserfs: Fix unwanted recursive reiserfs lock in reiserfs_unlink()
reiserfs: Fix journal mutex <-> inode mutex lock inversion
reiserfs: Safely acquire i_mutex from reiserfs_for_each_xattr
reiserfs: Safely acquire i_mutex from xattr_rmdir
fs/reiserfs/bitmap.c | 3 +++
fs/reiserfs/inode.c | 5 +++--
fs/reiserfs/journal.c | 18 ++++++++++++++----
fs/reiserfs/lock.c | 9 +++++++++
fs/reiserfs/namei.c | 7 ++++---
fs/reiserfs/xattr.c | 26 ++++++++++++++++++++------
include/linux/reiserfs_fs.h | 26 ++++++++++++++++++++++++++
7 files changed, 79 insertions(+), 15 deletions(-)
next reply other threads:[~2010-01-02 1:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 1:27 Frederic Weisbecker [this message]
2010-01-02 13:41 ` Andi Kleen
2010-01-02 16:36 ` Frederic Weisbecker
2010-01-02 17:43 ` reiserfs broken in 2.6.32 was " Andi Kleen
2010-01-02 19:02 ` Frederic Weisbecker
2010-01-02 19:23 ` Andi Kleen
2010-01-02 20:11 ` Frederic Weisbecker
2010-01-02 20:33 ` Andi Kleen
2010-01-02 20:54 ` Frederic Weisbecker
2010-01-02 21:10 ` Ingo Molnar
2010-01-02 21:42 ` Ingo Molnar
2010-01-02 21:01 ` tytso
2010-01-02 21:06 ` Frederic Weisbecker
2010-01-02 23:36 ` tytso
2010-01-02 23:43 ` Christian Kujau
2010-01-03 1:16 ` Frederic Weisbecker
2010-01-03 1:52 ` Frederic Weisbecker
2010-01-03 2:05 ` Christian Kujau
2010-01-03 3:27 ` tytso
2010-01-04 20:20 ` Frederic Weisbecker
2010-01-02 20:11 ` Ingo Molnar
2010-01-02 22:18 ` Ingo Molnar
2010-01-02 19:19 ` Linus Torvalds
2010-01-02 19:21 ` Linus Torvalds
2010-01-02 19:24 ` Frederic Weisbecker
2010-01-02 19:22 ` Frederic Weisbecker
2010-02-14 18:14 Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262395636-8647-1-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.beregalov@gmail.com \
--cc=chris.mason@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®