From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925Ab0ADThg (ORCPT ); Mon, 4 Jan 2010 14:37:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753896Ab0ADThb (ORCPT ); Mon, 4 Jan 2010 14:37:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871Ab0ADTha (ORCPT ); Mon, 4 Jan 2010 14:37:30 -0500 Subject: Re: [PATCH] libsrp: fix compile failure From: James Bottomley To: Stefani Seibold Cc: Alan Cox , Jiri Kosina , Linus Torvalds , Andrew Morton , linux-kernel , linux-scsi In-Reply-To: <1262633054.4814.21.camel@wall-e> References: <1262200866.2749.226.camel@mulgrave.site> <1262625721.2724.158.camel@mulgrave.site> <20100104173530.48690e39@lxorguk.ukuu.org.uk> <1262633054.4814.21.camel@wall-e> Content-Type: text/plain; charset="UTF-8" Date: Mon, 04 Jan 2010 13:37:17 -0600 Message-Id: <1262633838.2724.218.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2010-01-04 at 20:24 +0100, Stefani Seibold wrote: > Am Montag, den 04.01.2010, 17:35 +0000 schrieb Alan Cox: > > > least once before it goes to Linus. There were originally technical > > > reasons why -mm wasn't in ... I just thought they'd been fixed by now. > > > > No - mm also caused problems with the kfifo merge of a core API change > > that didn't go via -next. > > > > Alan > > I tried my best to port everything to the new kfifo API. But it was not > possible to check it against every architecture. That's what linux-next is for: to make at least this compile checking against all of our architectures more of a reality. It's still missing bits, and some of the ports (*cough* parisc *cough*) compile against linux-next rather infrequently, but it's far better than nothing. > x86 and x86_64 was > compile clean. I think the missing #include was not a big thing. It's easily fixable, yes ... breaking the build *is* a pretty big thing because of the fallout it causes (for ppc: about ~100 instant WTF moments followed by grubbing around in git to find the cause). It's also an indicator of future problems. Realistically, all API changes should go into linux-next both to prevent this sort of thing from happening and to see if we have any other pending conflicts that may cause problems. James