From: Jiri Slaby <jslaby@suse.cz>
To: jirislaby@gmail.com
Cc: linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: [PATCH] IA64: use helpers for rlimits
Date: Wed, 6 Jan 2010 16:24:30 +0100 [thread overview]
Message-ID: <1262791479-26594-2-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1262791479-26594-1-git-send-email-jslaby@suse.cz>
Make sure compiler won't do weird things with limits. E.g. fetching
them twice may return 2 different values after writable limits are
implemented.
I.e. either use rlimit helpers added in
3e10e716abf3c71bdb5d86b8f507f9e72236c9cd
or ACCESS_ONCE if not applicable.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org
---
arch/ia64/kernel/perfmon.c | 2 +-
arch/ia64/mm/init.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
index 5246285..6bcbe21 100644
--- a/arch/ia64/kernel/perfmon.c
+++ b/arch/ia64/kernel/perfmon.c
@@ -2293,7 +2293,7 @@ pfm_smpl_buffer_alloc(struct task_struct *task, struct file *filp, pfm_context_t
* if ((mm->total_vm << PAGE_SHIFT) + len> task->rlim[RLIMIT_AS].rlim_cur)
* return -ENOMEM;
*/
- if (size > task->signal->rlim[RLIMIT_MEMLOCK].rlim_cur)
+ if (size > task_rlimit(task, RLIMIT_MEMLOCK))
return -ENOMEM;
/*
diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index b9609c6..7c0d481 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -91,7 +91,7 @@ dma_mark_clean(void *addr, size_t size)
inline void
ia64_set_rbs_bot (void)
{
- unsigned long stack_size = current->signal->rlim[RLIMIT_STACK].rlim_max & -16;
+ unsigned long stack_size = rlimit_max(RLIMIT_STACK) & -16;
if (stack_size > MAX_USER_STACK_SIZE)
stack_size = MAX_USER_STACK_SIZE;
--
1.6.5.7
next prev parent reply other threads:[~2010-01-06 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 15:24 [PATCH] core: posix-cpu-timers, cleanup rlimits usage Jiri Slaby
2010-01-06 15:24 ` Jiri Slaby [this message]
2010-01-06 15:24 ` [PATCH] PPC: use helpers for rlimits Jiri Slaby
2010-01-06 15:24 ` [PATCH] S390: " Jiri Slaby
2010-01-07 9:24 ` Martin Schwidefsky
2010-01-06 15:24 ` [PATCH] SPARC: " Jiri Slaby
2010-01-08 8:03 ` David Miller
2010-01-06 15:24 ` [PATCH] X86: " Jiri Slaby
2010-01-06 15:24 ` [PATCH] FS: " Jiri Slaby
2010-01-06 15:24 ` [PATCH] MM: " Jiri Slaby
2010-01-06 15:24 ` [PATCH] core: " Jiri Slaby
2010-01-06 15:24 ` [PATCH] infiniband: " Jiri Slaby
2010-01-06 15:24 ` [PATCH] ipc: " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262791479-26594-2-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=fenghua.yu@intel.com \
--cc=jirislaby@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®