From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901Ab0AGOkh (ORCPT ); Thu, 7 Jan 2010 09:40:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752692Ab0AGOkg (ORCPT ); Thu, 7 Jan 2010 09:40:36 -0500 Received: from cantor.suse.de ([195.135.220.2]:50921 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768Ab0AGOkf (ORCPT ); Thu, 7 Jan 2010 09:40:35 -0500 Subject: Re: [PATCH,RESEND] scsi: use __uX types for headers exported to user space From: James Bottomley To: Peter Korsgaard Cc: james.smart@emulex.com, linux-scsi@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org In-Reply-To: <1262874005-25089-1-git-send-email-jacmet@sunsite.dk> References: <1262874005-25089-1-git-send-email-jacmet@sunsite.dk> Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Jan 2010 09:40:29 -0500 Message-Id: <1262875229.3025.4.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-01-07 at 15:20 +0100, Peter Korsgaard wrote: > Commit 9e4f5e29 (FC Pass Thru support) exported a number of header files > in include/scsi to user space, but didn't change the uX types to the > userspace-compatible __uX types. Without that you'll get compile errors > when including them - E.G.: > > /tmp/include/scsi/scsi.h:145: error: expected specifier-qualifier-list > before ‘u8’ > > Signed-off-by: Peter Korsgaard > --- > No feedback since 27/11, resending. OK, so to summarise the list discussion, the current status is that the SCSI exports are irrelevant because glibc currently ignores the include/scsi namespace provided by the kernel. So, we have three options: 1. Bring our exports up to the point where they can replace glibc's include/scsi/scsi.h and the rest. This requires a line by line analysis of what's in glibc and an update to our include to provide or remove as necessary. After this is done we can try to persuade the glibc people to turn over the include/scsi namespace to us. 2. Kill the kbuild exports and make everyone go via the glibc tree (current state). 3. Move the kernel include/scsi to a more conventional namespace (like inside include/linux) so glibc will pick it up. So far we've had people supporting all three. I'm inclined to say that I'd favour 1, but the first patch trying to do any of them would be the best starting ground for a discussion. James