From: srinidhi kasagar <srinidhi.kasagar@stericsson.com>
To: Linus WALLEIJ <linus.walleij@stericsson.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
Sachin VERMA <sachin.verma@st.com>,
Andrea GALLO <andrea.gallo@stericsson.com>, <rubini@unipv.it>
Subject: RE: [PATCH 1/2] i2c: Add support for Ux500/Nomadik I2C controller
Date: Fri, 8 Jan 2010 02:39:02 +0530 [thread overview]
Message-ID: <1262898542.1026.6.camel@vinay-desktop> (raw)
In-Reply-To: <A6D19A13FE030A409EC4362C172E091F0E30CDB5@eseldmw101.eemea.ericsson.se>
On Thu, 2010-01-07 at 21:37 +0100, Linus WALLEIJ wrote:
> > +++ b/drivers/i2c/busses/i2c-nmk.c
> (...)
> > + dev->irq = platform_get_irq(pdev, 0);
> > + ret = request_irq(dev->irq, i2c_irq_handler, IRQF_DISABLED,
> > + DRIVER_NAME, dev);
>
> Since I2C IRQs can be a bit tedious, could this be converted
> to a request_threaded_irq()? OK I know that is probably a bit
> intrusive and can very well be done later (so no blocker) but
> think about it.
hmm..I tried using request_threaded_irq, but seems not to be working at
the first step, did not debug further. So, I will post v2 patch fixing
the rest of your comments. Once I have this driver working fully with
threaded implementation, I will post a patch on top of it. Hope this is
OK.
Srinidhi
prev parent reply other threads:[~2010-01-08 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 13:41 srinidhi kasagar
2010-01-07 1:38 ` srinidhi kasagar
2010-01-07 14:04 ` Jean Delvare
2010-01-07 20:37 ` Linus Walleij
2010-01-07 21:09 ` srinidhi kasagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262898542.1026.6.camel@vinay-desktop \
--to=srinidhi.kasagar@stericsson.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=andrea.gallo@stericsson.com \
--cc=ben-linux@fluff.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@unipv.it \
--cc=sachin.verma@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome