From: Tiago Vignatti <tiago.vignatti@nokia.com>
To: Dave Airlie <airlied@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Paulo R. Zanoni" <przanoni@gmail.com>,
Henry Zhao <Henry.Zhao@Sun.COM>,
Andy Getzendanner <james.getzendanner@students.olin.edu>,
Brad Spengler <spender@grsecurity.net>,
"dri-devel@lists.sf.net" <dri-devel@lists.sf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tiago Vignatti <tiago.vignatti@nokia.com>
Subject: [PATCH] vgaarb: fix trylock behaviour accordingly vga_tryget return value
Date: Tue, 12 Jan 2010 19:58:32 +0200 [thread overview]
Message-ID: <1263319113-6631-2-git-send-email-tiago.vignatti@nokia.com> (raw)
In-Reply-To: <1263319113-6631-1-git-send-email-tiago.vignatti@nokia.com>
From: Henry Zhao <Henry.Zhao@Sun.COM>
Signed-off-by: Tiago Vignatti <tiago.vignatti@nokia.com>
---
Henry, can you Signed-off-by there?
drivers/gpu/vga/vgaarb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index 2f6cf69..0f5f64d 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -935,7 +935,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user * buf,
goto done;
}
- if (vga_tryget(pdev, io_state)) {
+ if (!vga_tryget(pdev, io_state)) {
/* Update the client's locks lists... */
for (i = 0; i < MAX_USER_CARDS; i++) {
if (priv->cards[i].pdev == pdev) {
--
1.6.0.4
next prev parent reply other threads:[~2010-01-12 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 17:58 [PATCH] vgaarb: fix typo deference when copying from userspace Tiago Vignatti
2010-01-12 17:58 ` Tiago Vignatti [this message]
2010-01-12 17:58 ` [PATCH-again] vgaarb: use MIT license Tiago Vignatti
2010-01-14 15:07 ` Paulo Zanoni
2010-01-13 4:05 ` [PATCH] vgaarb: fix trylock behaviour accordingly vga_tryget return value Henry Zhao
2010-01-12 18:56 ` [PATCH] vgaarb: fix typo deference when copying from userspace Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263319113-6631-2-git-send-email-tiago.vignatti@nokia.com \
--to=tiago.vignatti@nokia.com \
--cc=Henry.Zhao@Sun.COM \
--cc=airlied@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.sf.net \
--cc=james.getzendanner@students.olin.edu \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=przanoni@gmail.com \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®