From: Ian Campbell <ian.campbell@citrix.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Christian Kujau <lists@nerdbynature.de>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Brian Gerst <brgerst@gmail.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] x86: kernel_thread -- initialize SS to a known state
Date: Wed, 13 Jan 2010 10:16:07 +0000 [thread overview]
Message-ID: <1263377768-19600-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1263377706.16526.12062.camel@zakaz.uk.xensource.com>
From: Cyrill Gorcunov <gorcunov@openvz.org>
Before the kernel_thread was converted into "C" we had
pt_regs::ss set to __KERNEL_DS (by SAVE_ALL asm macro).
Though I must admit I didn't find any *explicit* load of
%ss from this structure the better to be on a safe side
and set it to a known value.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
arch/x86/kernel/process.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index c6ee241..02c3ee0 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -288,6 +288,8 @@ int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
regs.es = __USER_DS;
regs.fs = __KERNEL_PERCPU;
regs.gs = __KERNEL_STACK_CANARY;
+#else
+ regs.ss = __KERNEL_DS;
#endif
regs.orig_ax = -1;
--
1.5.6.5
next prev parent reply other threads:[~2010-01-13 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 10:15 [GIT PULL] update paravirt after f443ff42 "x86: Sync 32/64-bit kernel_thread" and related Ian Campbell
2010-01-13 10:16 ` Ian Campbell [this message]
2010-01-13 16:39 ` [tip:x86/urgent] x86: kernel_thread() -- initialize SS to a known state tip-bot for Cyrill Gorcunov
2010-01-13 10:16 ` [PATCH] xen: 64 bit kernel RPL should be 0 Ian Campbell
2010-01-13 16:39 ` [tip:x86/urgent] x86: xen: 64-bit " tip-bot for Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263377768-19600-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=brgerst@gmail.com \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®