From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] tracing: Drop the tr check from the graph tracing path
Date: Thu, 14 Jan 2010 10:06:49 -0500 [thread overview]
Message-ID: <1263481609.28171.3845.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1263453795-7496-1-git-send-regression-fweisbec@gmail.com>
On Thu, 2010-01-14 at 08:23 +0100, Frederic Weisbecker wrote:
> Each time we save a function entry from the function graph tracer,
> we check if the trace array is set, which is wasteful because it is
> set anyway before we start the tracer. All we need is to ensure we
> have good read and write orderings. When we set the trace array, we
> just need to guarantee it to be visible before starting tracing.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> kernel/trace/trace_functions_graph.c | 19 ++++++++++---------
> 1 files changed, 10 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2010-01-14 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 7:23 Frederic Weisbecker
2010-01-14 15:06 ` Steven Rostedt [this message]
2010-01-17 18:30 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263481609.28171.3845.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®