mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.33-rc2: Xen/Guest switching to user mode with no user page tables
Date: Fri, 15 Jan 2010 11:29:10 +0000	[thread overview]
Message-ID: <1263554950.16526.27033.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.01.1001150011480.3483@bogon.housecafe.de>

On Fri, 2010-01-15 at 00:36 -0800, Christian Kujau wrote:
> On Sun, 10 Jan 2010 at 12:59, Ian Campbell wrote:
> > The correct fix is for the Xen backend to declare kernel RPL == 0 for 64
> > bit guests -- the hyervisor already takes care of all the necessary
> > squashing to ring 3 transparently (because making the guest worry about
> > it would break the very common assumption that you can distinguish user
> > from kernel CS by RPL).
> 
> Yes' it's a 64bit guest, I should have mentioned this from the beginning. 

That's OK, I already knew because only 64 bit guests have a separate
user page table.

> With the 2 patches from Ian and Cyrill applied, the DomU is now booting 
> fine again (currently running mainline -git).

Excellent. These patches are both now in -tip. They are in the urgent
branch so I assume they will be heading to mainline before too long.

> Cyrill: with your patch alone (for arch/x86/kernel/process.c), the DomU
> is still not booting, Dom0 "xm dmesg" reporting the same error. As it's
> working with both patches applied, should I try to test with only Ian's
> patch (for arch/x86/xen/enlighten.c) applied?

It's OK, both patches are definitely required to fix 64 bit guests so
there is no point in testing just one or the other.

Ian.

-- 
Ian Campbell
Current Noise: Exodus - Scar Spangled Banner

War is much too serious a matter to be entrusted to the military.
		-- Clemenceau


  reply	other threads:[~2010-01-15 11:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  1:03 Christian Kujau
2010-01-06  3:38 ` Jeremy Fitzhardinge
2010-01-06  3:48   ` Christian Kujau
2010-01-06  5:14     ` Jeremy Fitzhardinge
2010-01-06 11:06   ` Christian Kujau
2010-01-06 11:21     ` Cyrill Gorcunov
2010-01-06 12:43       ` Christian Kujau
2010-01-07 19:06         ` Christian Kujau
2010-01-07 19:20           ` Cyrill Gorcunov
2010-01-07 19:31             ` Christian Kujau
2010-01-07 19:34               ` Cyrill Gorcunov
2010-01-07 19:19         ` H. Peter Anvin
2010-01-07 19:30           ` Christian Kujau
2010-01-08 21:50             ` Cyrill Gorcunov
2010-01-09 23:55               ` Christian Kujau
2010-01-10  1:50               ` Brian Gerst
2010-01-10  8:09                 ` Cyrill Gorcunov
2010-01-10 12:59                   ` Ian Campbell
2010-01-10 13:36                     ` Cyrill Gorcunov
2010-01-10 13:49                       ` Cyrill Gorcunov
2010-01-10 14:05                         ` Ian Campbell
2010-01-15  8:36                     ` Christian Kujau
2010-01-15 11:29                       ` Ian Campbell [this message]
2010-01-15 12:03                         ` Cyrill Gorcunov
2010-01-15 12:00                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263554950.16526.27033.camel@zakaz.uk.xensource.com \
    --to=ijc@hellion.org.uk \
    --cc=brgerst@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®