From: eparis@redhat.com
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, stable@kernel.org, faure@kde.org,
bhutchings@solarflare.com, akpm@linux-foundation.org,
linux@horizon.com, Eric Paris <eparis@redhat.com>
Subject: [PATCH 2/2] inotify: only warn once for inotify problems
Date: Fri, 15 Jan 2010 12:12:25 -0500 [thread overview]
Message-ID: <1263575545-26703-2-git-send-email-eparis@redhat.com> (raw)
In-Reply-To: <1263575545-26703-1-git-send-email-eparis@redhat.com>
From: Eric Paris <eparis@redhat.com>
inotify will WARN() if it finds that the idr and the fsnotify internals
somehow got out of sync. It was only supposed to do this once but due
to this stupid bug it would warn every single time a problem was detected.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
fs/notify/inotify/inotify_fsnotify.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c
index c9ee67b..1afb0a1 100644
--- a/fs/notify/inotify/inotify_fsnotify.c
+++ b/fs/notify/inotify/inotify_fsnotify.c
@@ -121,7 +121,7 @@ static int idr_callback(int id, void *p, void *data)
if (warned)
return 0;
- warned = false;
+ warned = true;
entry = p;
ientry = container_of(entry, struct inotify_inode_mark_entry, fsn_entry);
--
1.6.5.3
prev parent reply other threads:[~2010-01-15 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 17:12 [PATCH 1/2] inotify: do not reuse watch descriptors eparis
2010-01-15 17:12 ` eparis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263575545-26703-2-git-send-email-eparis@redhat.com \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=faure@kde.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®