From: Joe Perches <joe@perches.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdogs: constify struct watchdog_info
Date: Tue, 19 Jan 2010 12:28:17 -0800 [thread overview]
Message-ID: <1263932897.18117.40.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100119085613.GA3804@infomag.iguana.be>
On Tue, 2010-01-19 at 09:56 +0100, Wim Van Sebroeck wrote:
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/watchdog/acquirewdt.c | 2 +-
> ...
> > drivers/watchdog/wm8350_wdt.c | 2 +-
> > 51 files changed, 52 insertions(+), 52 deletions(-)
>
> NAK (Although the patch itself is good).
No worries.
> I created another patch that does this and moves the struct
> out of the ioctl call as part of the generic watchdog conversion.
Great.
I did send you awhile ago a patch series
to convert to pr_fmt() and pr_<level>.
http://lkml.org/lkml/2009/7/21/5
Do you still eventually want those?
cheers, Joe
next prev parent reply other threads:[~2010-01-19 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 1:45 Joe Perches
2010-01-19 8:56 ` Wim Van Sebroeck
2010-01-19 20:28 ` Joe Perches [this message]
2010-01-19 21:02 ` Wim Van Sebroeck
2010-01-19 21:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263932897.18117.40.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®