From: Steven Rostedt <rostedt@goodmis.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, Greg KH <greg@kroah.com>,
Andy Whitcroft <apw@canonical.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: Lots of bugs with current->state = TASK_*INTERRUPTIBLE
Date: Thu, 21 Jan 2010 15:18:24 -0500 [thread overview]
Message-ID: <1264105104.31321.298.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4B58B1B3.6000502@caviumnetworks.com>
On Thu, 2010-01-21 at 11:57 -0800, David Daney wrote:
> >> Since the current CPU sees the memory accesses in order, what can be
> >> happening on other CPUs that would require a full mb()?
> >
> > Lets look at a hypothetical situation with:
> >
> > add_wait_queue();
> > current->state = TASK_UNINTERRUPTIBLE;
> > smp_wmb();
> > if (!x)
> > schedule();
> >
> >
> >
> > Then somewhere we probably have:
> >
> > x = 1;
> > smp_wmb();
> > wake_up(queue);
> >
> >
> >
> > CPU 0 CPU 1
> > ------------ -----------
> > add_wait_queue();
> > (cpu pipeline sees a load
> > of x ahead, and preloads it)
>
>
> This is what I thought.
>
> My cpu (Cavium Octeon) does not have out of order reads, so my wmb() is
Can you have reads that are out of order wrt writes? Because the above
does not have out of order reads. It just had a read that came before a
write. The above code could look like:
(hypothetical assembly language)
ld r2, TASK_UNINTERRUPTIBLE
st r2, (current->state)
wmb
ld r1, (x)
cmp r1, 0
Is it possible for the CPU to do the load of r1 before storing r2? If
so, then the bug still exists.
-- Steve
> in fact a full mb() from the point of view of the current CPU. So I
> think I could weaken my bariers in set_current_state() and still get
> correct operation. However as you say...
>
next prev parent reply other threads:[~2010-01-21 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 20:29 Steven Rostedt
2010-01-19 20:58 ` Julia Lawall
2010-01-19 21:08 ` Steven Rostedt
2010-01-21 10:47 ` Julia Lawall
2010-01-21 10:53 ` Frederic Weisbecker
2010-01-21 10:56 ` Peter Zijlstra
2010-01-21 10:59 ` Frederic Weisbecker
2010-01-21 17:31 ` Steven Rostedt
2010-01-21 18:12 ` Julia Lawall
2010-01-21 19:18 ` David Daney
2010-01-21 19:34 ` Steven Rostedt
2010-01-21 19:57 ` David Daney
2010-01-21 20:18 ` Steven Rostedt [this message]
2010-01-21 20:21 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264105104.31321.298.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=ddaney@caviumnetworks.com \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®