From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [RFC PATCH 07/10] ftrace: Make the function hashlist concurrently usable
Date: Fri, 22 Jan 2010 02:16:19 +0100 [thread overview]
Message-ID: <1264122982-1553-8-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1264122982-1553-1-git-send-regression-fweisbec@gmail.com>
Allow the function hashlist to be usable by simultaneous users.
The function tracers can then plug in for their own needs.
This introduces a get/put_function_hlist() that keeps track
of the hashlist users for allocation and release.
We also introduce function_hlist_reset_profile() that resets
the function profiling statistics on a function hashlist already
in use.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/trace/ftrace.c | 5 ++-
kernel/trace/functions_hlist.c | 56 ++++++++++++++++++++++++++++++++++++++-
kernel/trace/functions_hlist.h | 5 ++-
3 files changed, 60 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 0ded01c..027743c 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -490,11 +490,12 @@ ftrace_profile_write(struct file *filp, const char __user *ubuf,
mutex_lock(&ftrace_profile_lock);
if (ftrace_profile_enabled ^ val) {
if (val) {
- ret = function_hlist_init();
+ ret = get_function_hlist();
if (ret < 0) {
cnt = ret;
goto out;
}
+ function_hlist_reset_profile();
ret = register_ftrace_profiler();
if (ret < 0) {
@@ -509,7 +510,7 @@ ftrace_profile_write(struct file *filp, const char __user *ubuf,
* so this acts like an synchronize_sched.
*/
unregister_ftrace_profiler();
- function_hlist_release();
+ put_function_hlist();
}
}
out:
diff --git a/kernel/trace/functions_hlist.c b/kernel/trace/functions_hlist.c
index c79c4c5..d682213 100644
--- a/kernel/trace/functions_hlist.c
+++ b/kernel/trace/functions_hlist.c
@@ -20,6 +20,39 @@
DEFINE_PER_CPU(struct func_hlist, func_hlist_cpu);
int functions_hash_bits __read_mostly;
+static atomic_t hlist_refcount;
+
+
+static void function_hlist_reset_profile_cpu(int cpu)
+{
+ struct func_hlist *hlist = &per_cpu(func_hlist_cpu, cpu);
+ struct hlist_head *head;
+ struct hlist_node *node;
+ struct func_node *rec;
+ int i;
+
+ for (i = 0; i < FUNCTIONS_HLIST_SIZE; i++) {
+ head = &hlist->hash[i];
+
+ if (hlist_empty(head))
+ continue;
+
+ hlist_for_each_entry(rec, node, head, node) {
+ rec->counter = 0;
+#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+ rec->time = 0;
+#endif
+ }
+ }
+}
+
+void function_hlist_reset_profile(void)
+{
+ int cpu;
+
+ for_each_online_cpu(cpu)
+ function_hlist_reset_profile_cpu(cpu);
+}
static void __function_hlist_release(struct func_hlist *hlist)
{
@@ -115,7 +148,7 @@ static int function_hlist_init_cpu(int cpu)
return 0;
}
-void function_hlist_release(void)
+static void function_hlist_release(void)
{
int cpu;
struct func_hlist *hlist;
@@ -126,7 +159,7 @@ void function_hlist_release(void)
}
}
-int function_hlist_init(void)
+static int function_hlist_init(void)
{
int cpu;
int ret = 0;
@@ -140,6 +173,25 @@ int function_hlist_init(void)
return ret;
}
+int get_function_hlist(void)
+{
+ int ret = 0;
+
+ if (atomic_inc_return(&hlist_refcount) == 1) {
+ ret = function_hlist_init();
+ if (ret < 0)
+ atomic_dec(&hlist_refcount);
+ }
+
+ return ret;
+}
+
+void put_function_hlist(void)
+{
+ if (!atomic_dec_return(&hlist_refcount))
+ function_hlist_release();
+}
+
struct func_node *
function_find_hlist_node(struct func_hlist *hlist, unsigned long ip)
{
diff --git a/kernel/trace/functions_hlist.h b/kernel/trace/functions_hlist.h
index 8001f95..a4655c7 100644
--- a/kernel/trace/functions_hlist.h
+++ b/kernel/trace/functions_hlist.h
@@ -35,5 +35,6 @@ function_find_hlist_node(struct func_hlist *hlist, unsigned long ip);
struct func_node *
function_hlist_record_alloc(struct func_hlist *hlist, unsigned long ip);
-int function_hlist_init(void);
-void function_hlist_release(void);
+int get_function_hlist(void);
+void put_function_hlist(void);
+void function_hlist_reset_profile(void);
--
1.6.2.3
next prev parent reply other threads:[~2010-01-22 1:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 1:16 [RFC PATCH 00/10] Ftrace functions hashlist Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 01/10] ftrace: Generalize the function hashlist from function profiler Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 02/10] ftrace: Ensure tracing has really stopped before leaving unregister_ftrace_graph Frederic Weisbecker
2010-01-22 1:51 ` Steven Rostedt
2010-01-22 2:04 ` Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 03/10] ftrace: Drop the ftrace_profile_enabled checks in tracing hot path Frederic Weisbecker
2010-01-22 2:05 ` Steven Rostedt
2010-01-22 2:28 ` Mathieu Desnoyers
2010-01-22 3:12 ` Steven Rostedt
2010-01-22 4:09 ` Mathieu Desnoyers
2010-01-22 4:52 ` Steven Rostedt
2010-01-22 12:34 ` Mathieu Desnoyers
2010-01-22 14:54 ` Masami Hiramatsu
2010-01-25 20:58 ` Frederic Weisbecker
2010-01-25 22:14 ` Masami Hiramatsu
2010-01-26 0:41 ` Frederic Weisbecker
2010-01-26 1:13 ` Mathieu Desnoyers
2010-01-26 1:37 ` Masami Hiramatsu
2010-01-27 21:55 ` [PATCH tracing/kprobes] kprobes: Disable booster when CONFIG_PREEMPT=y Masami Hiramatsu
2010-01-28 1:08 ` Mathieu Desnoyers
2010-01-28 4:21 ` Ananth N Mavinakayanahalli
2010-01-29 9:21 ` Ingo Molnar
2010-01-29 11:30 ` Peter Zijlstra
2010-01-29 14:52 ` Masami Hiramatsu
2010-01-29 17:08 ` Mathieu Desnoyers
2010-01-29 17:15 ` Peter Zijlstra
2010-01-29 17:27 ` Mathieu Desnoyers
2010-01-29 17:32 ` Masami Hiramatsu
2010-01-22 2:43 ` [RFC PATCH 03/10] ftrace: Drop the ftrace_profile_enabled checks in tracing hot path Frederic Weisbecker
2010-01-22 3:05 ` Steven Rostedt
2010-01-25 20:52 ` Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 04/10] ftrace: Ensure buffers are visibles to tracing callbacks right away Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 05/10] ftrace: Drop buffer check in function profiler callbacks Frederic Weisbecker
2010-01-25 6:17 ` Lai Jiangshan
2010-01-30 20:47 ` Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 06/10] ftrace: Release the function hlist if we don't need it anymore Frederic Weisbecker
2010-01-25 6:41 ` Lai Jiangshan
2010-01-30 21:14 ` Frederic Weisbecker
2010-01-22 1:16 ` Frederic Weisbecker [this message]
2010-01-22 1:16 ` [PATCH 08/10] tracing: Simplify test for function_graph tracing Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 09/10] tracing: Use the hashlist for graph function Frederic Weisbecker
2010-01-25 8:50 ` Lai Jiangshan
2010-01-30 21:19 ` Frederic Weisbecker
2010-01-22 1:16 ` [RFC PATCH 10/10] ftrace: Factorize search and insertion in the function hashlist Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264122982-1553-8-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®