mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Joerg Roedel <joerg.roedel@amd.com>,
	stable@kernel.org
Subject: [PATCH 4/5] x86/amd-iommu: Fix deassignment of a device from the pt_domain
Date: Fri, 22 Jan 2010 18:18:12 +0100	[thread overview]
Message-ID: <1264180693-27197-5-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1264180693-27197-1-git-send-email-joerg.roedel@amd.com>

Deassigning a device from the passthrough domain does not
work and breaks device assignment to kvm guests. This patch
fixes the issue.

Cc: stable@kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 751ce73..adb0ba0 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -1511,9 +1511,11 @@ static void __detach_device(struct device *dev)
 
 	/*
 	 * If we run in passthrough mode the device must be assigned to the
-	 * passthrough domain if it is detached from any other domain
+	 * passthrough domain if it is detached from any other domain.
+	 * Make sure we can deassign from the pt_domain itself.
 	 */
-	if (iommu_pass_through && dev_data->domain == NULL)
+	if (iommu_pass_through &&
+	    (dev_data->domain == NULL && domain != pt_domain))
 		__attach_device(dev, pt_domain);
 }
 
-- 
1.6.6



  parent reply	other threads:[~2010-01-22 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 17:18 [git pull] IOMMU fixes for 2.6.33-rc5 Joerg Roedel
2010-01-22 17:18 ` [PATCH 1/5] x86/amd-iommu: Fix possible integer overflow Joerg Roedel
2010-01-22 17:18 ` [PATCH 2/5] x86/amd-iommu: Fix NULL pointer dereference in __detach_device() Joerg Roedel
2010-01-22 17:18 ` [PATCH 3/5] x86/amd-iommu: Fix IOMMU-API initialization for iommu=pt Joerg Roedel
2010-01-22 17:18 ` Joerg Roedel [this message]
2010-01-22 17:18 ` [PATCH 5/5] lib/dma-debug.c: mark file-local struct symbol static Joerg Roedel
2010-01-27 10:04 ` [git pull] IOMMU fixes for 2.6.33-rc5 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264180693-27197-5-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®