mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Himanshu Chauhan <himanshu@symmetricore.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] USB-IP: Small clean up based on previous comments.
Date: Fri, 22 Jan 2010 23:50:37 +0530	[thread overview]
Message-ID: <1264184437-6971-2-git-send-email-himanshu@symmetricore.com> (raw)
In-Reply-To: <1264184437-6971-1-git-send-email-himanshu@symmetricore.com>

Hi,

I am trying to take a look at usb-ip to get it into mainline.
This is a small patch (my first patch ever) in this regard.

Please let me know the comments.

Thanks

Regards
Himanshu

---
 drivers/staging/usbip/usbip_common.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index ddb6f5f..57c0ff5 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -55,10 +55,7 @@ static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
 static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
 		const char *buf, size_t count)
 {
-	unsigned long flag;
-
-	sscanf(buf, "%lx", &flag);
-	usbip_debug_flag = flag;
+	sscanf(buf, "%lx", &usbip_debug_flag);
 
 	return count;
 }
-- 
1.6.3.3


      reply	other threads:[~2010-01-22 18:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 18:20 Himanshu Chauhan
2010-01-22 18:20 ` Himanshu Chauhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264184437-6971-2-git-send-email-himanshu@symmetricore.com \
    --to=himanshu@symmetricore.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®