From: Joe Perches <joe@perches.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] get_maintainer.pl: teach git log to use --no-color
Date: Fri, 22 Jan 2010 12:16:33 -0800 [thread overview]
Message-ID: <1264191393.32383.128.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1264163484.2143.13.camel@localhost>
lOn Fri, 2010-01-22 at 12:31 +0000, Richard Kennedy wrote:
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 090f248..2cae27a 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -74,7 +74,7 @@ my %VCS_cmds;
> my %VCS_cmds_git = (
> "execute_cmd" => \&git_execute_cmd,
> "available" => '(which("git") ne "") && (-d ".git")',
> - "find_signers_cmd" => "git log --since=\$email_git_since -- \$file",
> + "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
> "find_commit_signers_cmd" => "git log -1 \$commit",
> "blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
> "blame_file_cmd" => "git blame -l \$file",
Actually, I take back my ack.
The line immediately below your change also needs --no-color
Can you make that change and resubmit please?
cheers, Joe
next prev parent reply other threads:[~2010-01-22 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 12:31 Richard Kennedy
2010-01-22 19:33 ` Joe Perches
2010-01-22 20:16 ` Joe Perches [this message]
2010-01-23 14:48 ` [PATCH] get_maintainer.pl: teach git log to use --no-color -- UPDATED Richard Kennedy
2010-01-23 18:43 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264191393.32383.128.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®