From: Joe Perches <joe@perches.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mm-commits@vger.kernel.org, bzolnier@gmail.com,
jens.axboe@oracle.com, marcin.slusarz@gmail.com,
shemminger@vyatta.com
Subject: Re: + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to -mm tree
Date: Wed, 27 Jan 2010 06:53:13 -0800 [thread overview]
Message-ID: <1264603993.14552.71.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4B600AB7.3070705@gmail.com>
On Wed, 2010-01-27 at 10:43 +0100, Jiri Slaby wrote:
> On 01/27/2010 01:37 AM, akpm@linux-foundation.org wrote:
> > @@ -3145,7 +3136,9 @@ static inline int raw_cmd_copyout(int cm
> > - COPYOUT(*ptr);
> > + ret = copy_to_user((void __user *)param, ptr, sizeof(*ptr));
> > + if (ret)
> > + return -EFAULT;
[]
> > - COPYIN(*ptr);
> > + ret = copy_from_user(ptr, (void __user *)param, sizeof(*ptr));
>
> Actually the casts are not needed anymore, are they?
There's still some char/void silliness.
It certainly could be improved/removed.
Do feel free to submit patches with your
desired level of changelog prolixity.
cheers, Joe
next prev parent reply other threads:[~2010-01-27 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201001270037.o0R0bqQC032566@imap1.linux-foundation.org>
2010-01-27 9:43 ` Jiri Slaby
2010-01-27 14:53 ` Joe Perches [this message]
2010-01-27 15:25 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264603993.14552.71.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®